Thanks Florian, that all sounds great. I had a look at your code examples, and while I'm not as big a Spring expert as others, it does look really straightforward and useful to me.
Also, if you haven't yet, please have a look through our
contributor guidelines for some general points on how to contribute, including legal stuff, and basic things like code formatting, git workflow, copyright headers, etc.
The best way to get code integration started technically is to open a pull request (aimed at the develop branch) with your code, so that we can start reviewing and testing it. Your project should become a new module, I'm currently thinking somewhere under core ("rdf4j-spring" as the artifact name sounds good to me for a first draft, directory core/spring ?) as this is library code rather than standalone tooling.
Because this is quite a substantial contribution, we will need to engage with the Eclipse IP team to get it reviewed before we can accept and merge. I will coordinate this, but it's easiest to get that started once the PR is up. Likely, they will want to get in touch with you and your employer directly to sort out any questions about intellectual property.
Looking forward to getting this started, and please don't hesitate to get in touch if you have any questions or comments!
Hi Jeen,
Good to hear that this may be of interest.
Am 2021-05-18 01:26, schrieb Jeen Broekstra:
> Can you share a bit more about the background of the project? Did you
> write it on your own or with other developers?
There is a little code from one other developer whose consent to
contributing will very likely not be a problem. I am also expecting to
get our employer's consent and that of the company we are doing the
project for.
> Is it already
> open-source?
No.
> And of course I'd definitely like to learn more about the
> code itself, any use cases or examples that you can share would be
> good.
Here are a few classes (some shortened):
There's:
* the spring Configuration.java showing how the RepositoryConnection is
pooled and wrapped in a caching and optionally a logging layer, how the
Rdf4jTemplate is instantiated, and how you can autodetect all your DAOs
* the Rdf4JTemplate (that one may be a little messy for some tastes but
we can clean it up)
* the DAO base class, Rdf4JDao
* a domain-specific 'ProjectDao' that uses all of this to provide some
CRUD operations
Can you give us an estimate of how large the contribution would
> be, roughly (lines of code)?
It's about 5400 lines of java code.
>
> Finally, a question for the future: assuming that we go ahead and
> integrate your contribution into RDF4J, are you intending to stay
> involved with maintaining it?
Yes. Availability may vary but I'd like to.
Best regards,
Florian
