Re: [lsp4e-dev] Suggestions required regarding changes to preferences of

[Manish Khurana <mkmanishkhurana98@xxxxxxxxx>]

Hi all,

I have filed bugs :- Bug - 536819 and Bug - 536820 for the issues I mentioned before. Please feel free to provide your suggestions regarding them.

Thanks,

Manish 

On Mon, Jun 11, 2018 at 12:52 PM Mickael Istria <mistria@xxxxxxxxxx> wrote:

On Mon, Jun 11, 2018 at 7:09 AM, Nathan Ridge <zeratul976@xxxxxxxxxxx> wrote:

Would we want this API to return a LanguageServerWrapper? And then would we call stop() and then start() on the LanguageServerWrapper?

Either the LanguageServerWrapper, or the LanguageServer directly. Both have a shutdown()/stop() method and stopping any of both should cascade to having the other ones (marked as) stopped to.

For consistency with other methods, I'd suggest returning LanguageServers rather than wrappers.

Note that unless it's useful for your specific case, you wouldn't need to call start() again on the wrapper as LSP4E should restart the server as soon as it's needed.

_______________________________________________
lsp4e-dev mailing list
lsp4e-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/lsp4e-dev