Re: [glassfish-dev] GlassFish updates for the javax -> jakarta transitio

["sawamura.hiroki@xxxxxxxxxxx" <sawamura.hiroki@xxxxxxxxxxx>]

Here is a summary of the status:

# Status:
  + Already merged
    - start/stop-domain on JDK 11.
    - deploy the simple Servlet application.
  + In Progress
    - Pass all unit tests.
    - Reviewing the changes to run GlassFish on both JDK 8 and JDK 11.
  + Pending
    - Pass all component tests(appserver/tests *) on both JDK 8 and JDK 11.
      (*)it is executed by Jenkins at 'tests' stage.
    - Run TCK on JDK 8. 
I think most of servers will work once the "In Progress" changes are committed.
//If we only need to run on JDK 11, most of the server are already working in the local environment. 
It expects to have a merge request by the end of this month.

# Issues:
  - the asm-all referenced by GlassFish does not support asm version 7.0 or later.
    ASM requires version 7.0 or later to be used on JDK 11.(https://asm.ow2.io/versions.html#7.0beta)
    // As a temporary workaround, I have rebuilt asm-repackaged using asm 7.0 instead of asm-all.
    // Maybe GlassFish can get around this by getting the latest version of asm packages directly on its own, but I haven't tried it yet.
  - OpenJDK and the latest Orb have removed the com.sun.jndi.cosnaming package referenced by GlassFish in these implementations.
    OpenJDK have removed it for JEP 320.
    Orb also have removed it at 4.1.1-b002, probably due to a duplicate implementation overlapped with JDK at the time.
    // As a temporary workaround, I have restored this package in orb and rebuilt it.

-----Original Message-----
From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Bill Shannon
Sent: Saturday, January 11, 2020 11:15 AM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>; Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] GlassFish updates for the javax -> jakarta transition

Me too.

Can you tell us the status of the JDK 11 work?

Is there a list of work items showing which ones have been completed and which ones are still being worked on?

If, for example, we could get most of the server to run with JDK 11, with just a few non-essential features still being worked on, it would be good to merge that work into the 6.0.0 (master) branch as soon as possible so that more work can be done in parallel.


Steve Millidge (Payara) wrote on 1/10/20 3:18 AM:
> That's fine by me
> 
> -----Original Message-----
> From: glassfish-dev-bounces@xxxxxxxxxxx 
> <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of 
> sawamura.hiroki@xxxxxxxxxxx
> Sent: 10 January 2020 10:39
> To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
> Subject: Re: [glassfish-dev] GlassFish updates for the javax -> 
> jakarta transition
> 
> Excuse me for jumping in.
> 
> I would like to continue development on either the 5.1.0-run-with-JDK11 branch or the 5.1.1 branch even if the 6.x branch is created.
> 
> I think the package migration will have a big impact on existing GlassFish customers so I would like to make GlassFish 5.1 run with JDK11+ as much as possible.
> 
> //Of course, I would also like to contribute to the 6.x branch.
> 
> Thanks
> Hiroki
> 
> -----Original Message-----
> From: glassfish-dev-bounces@xxxxxxxxxxx 
> <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Steve Millidge 
> (Payara)
> Sent: Friday, January 10, 2020 6:45 PM
> To: Bill Shannon <bill.shannon@xxxxxxxxxx>; glassfish developer 
> discussions <glassfish-dev@xxxxxxxxxxx>
> Subject: Re: [glassfish-dev] GlassFish updates for the javax -> 
> jakarta transition
> 
> Not sure we need +1s for the master branch, lazy consensus and all that. Let's say unless someone objects we will move master to 6.x. I created this issue https://github.com/eclipse-ee4j/glassfish/issues/22874 which the PR can reference. If anybody objects please shout. I created milestones for 6.0.0 and 5.1.1 so that issues can be given milestones.
> 
> For the JDK 11 work I think it depends on how Hiroki wants to work.
> 
> Steve
> 
> -----Original Message-----
> From: Bill Shannon <bill.shannon@xxxxxxxxxx>
> Sent: 10 January 2020 03:23
> To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>; Steve 
> Millidge (Payara) <steve.millidge@xxxxxxxxxxx>
> Subject: Re: [glassfish-dev] GlassFish updates for the javax -> 
> jakarta transition
> 
> Steve Millidge (Payara) wrote on 1/9/20 2:49 AM:
>> My preference would be to switch master to 6.x and create a maintenance branch off the 5.1.0 tag.
> 
> I agree.  Do we need to start collecting +1's?  :-)
> 
>> On the list of things to do it looks reasonable but won't know for sure until a first pass through it.
> 
> Yes, I'm sure there's at least a few things that are missing.
> 
>> One other thing is whether we remove the support for the removed apis.
> 
> We can't remove support for any optional APIs since we still need a Compatible Implementation that supports them all.
> 
> Separately we need to decide what level of backwards compatibility support Eclipse GlassFish will offer.  I'm still hoping that someone will create a backwards compatibility project that can be shared by multiple Jakarta EE implementations.  It would be useful to prototype such a project in GlassFish.
> 
> Even ignoring backwards compatibility, my understanding is that the platform TCK depends heavily on the Deployment API, so if we remove that we're going to have to figure out what to replace it with.
> 
> 
> What's you're feeling on the "javax -> jakarta" work vs. the JDK 11 work?
> How do we coordinate them?
> 
> 
>> Steve
>>
>>
>> -----Original Message-----
>> From: glassfish-dev-bounces@xxxxxxxxxxx 
>> <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Bill Shannon
>> Sent: 08 January 2020 18:31
>> To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
>> Subject: [glassfish-dev] GlassFish updates for the javax -> jakarta 
>> transition
>>
>> Do we have a plan for how to manage the GlassFish project as some of the APIs start the transition from javax to jakarta?
>>
>> (Note that I asked the same question of the TCK project; it would be nice to use the same conventions there and here and coordinate the work.
>>
>> Should these contributions be made in a new "6.0.0" branch?
>>
>> Is it time to convert the master branch to "6.0.0-SNAPSHOT" and move any 5.x maintenance to a separate maintenance branch?
>>
>> Presumably any update to the API to move to the jakarta namespace 
>> should include
>>
>> - update of the API jar file dependency
>> - update of the implementation (included, or dependency)
>> - update of any usage on the APIs in other GlassFish code, e.g., 
>> admin console
>> - update of any tests in the GlassFish repository
>>   (are all tests still valid, functional, and regularly executed?)
>> - update of any documentation that uses the APIs, e.g., in examples
>> - update of any CI tests that depend on the API or jar file names
>> - update of the API jar files in the jakartaee-api project
>> - anything I forgot?
>> _______________________________________________
>> glassfish-dev mailing list
>> glassfish-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or 
>> unsubscribe from this list, visit 
>> https://www.eclipse.org/mailman/listinfo/glassfish-dev
>> _______________________________________________
>> glassfish-dev mailing list
>> glassfish-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or 
>> unsubscribe from this list, visit 
>> https://www.eclipse.org/mailman/listinfo/glassfish-dev
>>
> _______________________________________________
> glassfish-dev mailing list
> glassfish-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or 
> unsubscribe from this list, visit 
> https://www.eclipse.org/mailman/listinfo/glassfish-dev
> _______________________________________________
> glassfish-dev mailing list
> glassfish-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or 
> unsubscribe from this list, visit 
> https://www.eclipse.org/mailman/listinfo/glassfish-dev
> _______________________________________________
> glassfish-dev mailing list
> glassfish-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or 
> unsubscribe from this list, visit 
> https://www.eclipse.org/mailman/listinfo/glassfish-dev
> 
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev