Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [openmq-dev] Staging 6.0.0 (final)?
Hi,

As 6.0.0 has not been used anywhere and was only in staging, there's no real need for a 6.0.1 perhaps. We can just restage 6.0.0 with PR-730. Otherwise it makes no sense to push out 6.0.0 to Maven Central if I understand correctly.

Anyway, HK2 3.0.0 is now in Maven Central, so I was about to push out 6.0.0 to Maven Central and let this be the version that GlassFish 6.0.0 ships, but I'm a bit confused between

"I think it shall be included in 6.0.0." and "stage it as 6.0.1, pass the Kit, submit change to GF"


I'm thinking it might be best now to stage https://github.com/eclipse-ee4j/openmq/tree/6.0.1 as 6.0.0, pass the TCK, and then push it out to Maven Central.

At any length, there's very little time left for this.

Kind regards,
Arjan Tijms










On Fri, Dec 4, 2020 at 9:24 AM Piotr Żygieło <piotr@xxxxxxxxxx> wrote:
Hi Team,

Regarding

There is new tyrus-standalone-client discovered from maven-central: https://github.com/eclipse-ee4j/openmq/pull/730 (Bump tyrus-standalone-client from 1.17 to 2.0.0)
that was never bumped to M1 or later.

We are not ready for that, and build fails with
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project mq-client: Compilation failure: Compilation failure:
[ERROR] /home/travis/build/eclipse-ee4j/openmq/mq/main/mq-client/src/main/java/com/sun/messaging/jmq/jmsclient/protocol/websocket/WebSocketConnectionHandler.java:[29,23] package javax.websocket does not exist

I updated PR-730 (javax->jakarta package rename).
I think it shall be included in 6.0.0.

With no other suggestions, I propose following:

- create branch 6.0.x (at fcfa88cc, https://github.com/eclipse-ee4j/openmq/tree/6.0.x)
- merge PR-730 changes to 6.0.x (https://github.com/eclipse-ee4j/openmq/pull/732), stage it as 6.0.1, pass the Kit, submit change to GF
(as this can simply be dropped by deleting new branch and not accepting in GF, I'm about to do it now).

- in current branch 6.0.0 - bump MQ version to 6.1.0-SNAPSHOT and then merge it to master
- merge (original) PR-730 to master
- continue development of new version 6.1 in master as nothing happened

Piotrek
_______________________________________________
openmq-dev mailing list
openmq-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/openmq-dev

Back to the top