Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [omr-dev] our coding standard 
Do you have a "favourite" file that demonstrates some of the C++
changes?  Picking a couple of files that demonstrate the pluses and
minuses of the different formats makes for a clearer conversation.


Eyeballing based on line count, and usage of C++ concepts [1], I'd say
a reasonable choice would be ./gc/base/standard/ConcurrentCardTableForWC.cpp|hpp 

Webkit:
* https://github.com/mgaudet/omr/blob/clang-format-webkit/gc/base/standard/ConcurrentCardTableForWC.hpp * https://github.com/mgaudet/omr/blob/clang-format-webkit/gc/base/standard/ConcurrentCardTableForWC.cpp * Reformat Commit: https://github.com/mgaudet/omr/commit/a7835ba1f25bb47159d659a09075a78fe3f291dd 

LLVM:
* https://github.com/mgaudet/omr/blob/clang-format-llvm/gc/base/standard/ConcurrentCardTableForWC.hpp * https://github.com/mgaudet/omr/blob/clang-format-llvm/gc/base/standard/ConcurrentCardTableForWC.cpp * Reformat commit: https://github.com/mgaudet/omr/commit/ff242b58e13c34dcb5a3c32b6f25342b51685e45 

Google:
* https://github.com/mgaudet/omr/blob/clang-format-google/gc/base/standard/ConcurrentCardTableForWC.hpp * https://github.com/mgaudet/omr/blob/clang-format-google/gc/base/standard/ConcurrentCardTableForWC.cpp * Reformat Commit:https://github.com/mgaudet/omr/commit/6dd2396059c99bf4bee4b3dc920975f54f24e507 

Chromium:
* https://github.com/mgaudet/omr/blob/clang-format-chromium/gc/base/standard/ConcurrentCardTableForWC.hpp * https://github.com/mgaudet/omr/blob/clang-format-chromium/gc/base/standard/ConcurrentCardTableForWC.cpp * https://github.com/mgaudet/omr/commit/525df0ee0881f7eebc06312adb227f487a9b56a6 


Mozilla:
* https://github.com/mgaudet/omr/blob/clang-format-mozilla/gc/base/standard/ConcurrentCardTableForWC.hpp * https://github.com/mgaudet/omr/blob/clang-format-mozilla/gc/base/standard/ConcurrentCardTableForWC.cpp * Reformat Commit: https://github.com/mgaudet/omr/commit/dd449ee99921e6cf75970e3171b73be809501689 


-- Matthew

[1]: Though, I'll note, it appears there is very sparse use of
     templates in OMR, so handling on them may be hard to see.

Back to the top