Re: [technology-pmc] git sign-off on contributions

[Wayne Beaton <wayne@xxxxxxxxxxx>]

You need a CQ for any contribution of more than 1000 LOC.

The contributor needs to have a signed the CLA for any contribution of any size.

HTH,

Wayne

On 29/01/15 12:36 AM, Jody Garnett wrote:

I also remember a lower limit, I can find reference to it in some project specific docs:

* http://wiki.eclipse.org/Mylyn/Contributor_Reference

Applying Patches
(Note: the section below is largely supplanted by the new Gerrit based review system, which takes care of many of these details including contributor IP approval.)

• Note that each patch should not contain more than 1000 added lines. For larger patches we need to invoke the IP Review process.

There was email from June describing the limit being raised from 250 to 1000:

* https://dev.eclipse.org/mhonarc/lists/eclipse.org-committers/msg00973.html

The thread links to http://eclipse.org/legal/EclipseLegalProcessPoster.pdf for clarification.

--

Jody Garnett

On 28 January 2015 at 20:13, david.w.smiley@xxxxxxxxx <david.w.smiley@xxxxxxxxx> wrote:

Thanks Jody; I read that document.  I did notice the 1000 line metric but that’s the bar for more processes, particularly a “CQ” (Contribution Questionnaire).  That makes sense to me.  But everything else I listed appears to be mandatory, even if it’s just 67 lines :-(  No one item in and of itself seems onerous to me but the sum of them seems out of balance with the paltry amount of IP at stake.  Sorry for complaining to you all whom I know can do nothing about the process — it is what it is.  But I am curious about how to handle the sign-off thing — how to add the sign-off after the fact.

~ David Smiley

Freelance Apache Lucene/Solr Search Consultant/Developer

http://www.linkedin.com/in/davidwsmiley

On Wed, Jan 28, 2015 at 8:01 PM, Jody Garnett <jody.garnett@xxxxxxxxx> wrote:

Let me check ... the language around 1000 lines is on this page (as a metric to determine a significant contribution).

 http://www.eclipse.org/legal/committerguidelines.php

Worth a read not sure if it will help ...

--

Jody Garnett

On 27 January 2015 at 13:42, david.w.smiley@xxxxxxxxx <david.w.smiley@xxxxxxxxx> wrote:

Hi PMC,

I recognize this list is more specific than need be for this question, so feel free to tell me where I should have directed it.

I haven’t yet accepted new code from people other than me to Spatial4j since joining LocationTech, so this question is a newbie one. I’ve got someone (not a committer) sending a pull request to me on GitHub for a feature I’d like to eventually merge.  It’s a change to existing source with license headers already there.  He didn’t know to use the “-s” sign off git flag.  What should be done?  Obviously he could redo it but we don’t want to make contributing a PITA.

I’ve reviewed the “Eclipse Legal Process Poster” http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf and it appears this contributor is required to create a Bugzilla/Gerrit account then create an issue and attach the code there (hopefully referencing via URL is acceptable?).  And then he must submit a CLA.

Note this contribution is very small, like 67 lines of code according to GitHub’s summary.  I thought I heard somewhere about a line-of-code barrier before going through all this ceremony; is that true?

~ David Smiley

Freelance Apache Lucene/Solr Search Consultant/Developer

http://www.linkedin.com/in/davidwsmiley

_______________________________________________
technology-pmc mailing list
technology-pmc@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://locationtech.org/mailman/listinfo/technology-pmc

_______________________________________________
technology-pmc mailing list
technology-pmc@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://locationtech.org/mailman/listinfo/technology-pmc

_______________________________________________
technology-pmc mailing list
technology-pmc@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://locationtech.org/mailman/listinfo/technology-pmc

_______________________________________________
technology-pmc mailing list
technology-pmc@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://locationtech.org/mailman/listinfo/technology-pmc

--
Wayne Beaton
@waynebeaton
The Eclipse Foundation