Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [technology-pmc] git sign-off on contributions

Let me check ... the language around 1000 lines is on this page (as a metric to determine a significant contribution).

 http://www.eclipse.org/legal/committerguidelines.php

Worth a read not sure if it will help ...




--
Jody Garnett

On 27 January 2015 at 13:42, david.w.smiley@xxxxxxxxx <david.w.smiley@xxxxxxxxx> wrote:
Hi PMC,

I recognize this list is more specific than need be for this question, so feel free to tell me where I should have directed it.

I haven’t yet accepted new code from people other than me to Spatial4j since joining LocationTech, so this question is a newbie one. I’ve got someone (not a committer) sending a pull request to me on GitHub for a feature I’d like to eventually merge.  It’s a change to existing source with license headers already there.  He didn’t know to use the “-s” sign off git flag.  What should be done?  Obviously he could redo it but we don’t want to make contributing a PITA.

I’ve reviewed the “Eclipse Legal Process Poster” http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf and it appears this contributor is required to create a Bugzilla/Gerrit account then create an issue and attach the code there (hopefully referencing via URL is acceptable?).  And then he must submit a CLA.

Note this contribution is very small, like 67 lines of code according to GitHub’s summary.  I thought I heard somewhere about a line-of-code barrier before going through all this ceremony; is that true?

~ David Smiley
Freelance Apache Lucene/Solr Search Consultant/Developer

_______________________________________________
technology-pmc mailing list
technology-pmc@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://locationtech.org/mailman/listinfo/technology-pmc


Back to the top