Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] Unable to access jarfile in test run
Here is the link for the PR
https://github.com/eclipse-ee4j/jakartaee-tck/pull/342

I appreciate it if you are able to review it.
Regards.
Gurkan

On Sat, Jun 20, 2020 at 1:32 AM Gurkan Erdogdu <cgurkanerdogdu@xxxxxxxxx> wrote:
Hi Scott, Alwin
I have finally implemented client stub generation in -deploy target in deploy.xml and updating common.xml and AutoDeployment class. Now, tests are running as expected.
I will create a PR for this.
Regards.
Gurkan

On Fri, Jun 19, 2020 at 3:18 PM Alwin Joseph <alwin.joseph@xxxxxxxxxx> wrote:

Hi Gurkan,

I thought the below ant command should be building the jars including cts.jar. I can see tslib target (install/jakartaee/bin/build.xml) compiles the files in implementation/sun/javaee and builds cts.jar. Are you running the same?

ant -f /root/install/jakartaee/bin/build.xml -Ddeliverabledir=jakartaee -Dbasedir=/root/install/jakartaee/bin clean.all build.all.jars

Below will compile all tck sources:

ant -f /root/install/jakartaee/bin/build.xml -Ddeliverabledir=jakartaee -Dbasedir=/root/install/jakartaee/bin -Djava.endorsed.dirs=/root/glassfish6/glassfish/modules/endorsed build.all

The recent build logs from CI:
https://ci.eclipse.org/jakartaee-tck/blue/rest/organizations/jenkins/pipelines/jakartaee-tck/branches/master/runs/712/nodes/19/steps/22/log/?start=0

Regards,
Alwin

On 19/06/20 5:01 pm, Gurkan Erdogdu wrote:
Hi Alwin
Is there any way to only compile ad build cts.jar? I tried the build.all.jars but even if I changed the AutoDeployment, still see the same file.
Regards.
Gurkan

On Fri, Jun 19, 2020 at 2:08 PM Gurkan Erdogdu <cgurkanerdogdu@xxxxxxxxx> wrote:
It worked thank you!

On Fri, Jun 19, 2020 at 2:02 PM Alwin Joseph <alwin.joseph@xxxxxxxxxx> wrote:

Gurkan,

On 19/06/20 4:17 pm, Gurkan Erdogdu wrote:

Hi Scott
I have implemented the stub generation in XML files and also in AutoDeployment (-deploy target).
I will try this but how can I repackage cts.jar under TS_HOME/lib?
I dont  want to compile all TCK suite, just CTS.jar. I did not find any XML  target do this?
Actually, I did run build.all.jars but it gives the following errors:

tmp/run_tck/jakartaeetck/bin/xml/ts.top.import.xml:690: unable to parse the schema. Error messages should have been provided
at com.sun.tools.xjc.XJCBase._doXJC(XJCBase.java:840)
at com.sun.tools.xjc.XJCBase.doXJC(XJCBase.java:787)
at com.sun.tools.xjc.XJCBase.execute(XJCBase.java:686)
at com.sun.tools.xjc.XJC2Task.execute(XJC2Task.java:25)
at com.sun.istac
Can you try setting -DenableExternalEntityProcessing=true for ANT_OPTS as it is there in docker/build_jakartaeetck.sh. The lib/jaxb*.jars  were updated recently with latest and we had to add this option to parse the schema. Can you share more logs if this does not solve.

Any idea?
Gurkan


On Thu, Jun 18, 2020 at 4:05 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:


On 6/18/20 5:15 AM, Alwin Joseph wrote:
> Thanks Scott.
>
> On 18/06/20 7:33 am, Scott Marlow wrote:
>>>
>>> We should be creating the ts_dep folder but still see:
>>>
>>> Error: Unable to access jarfile
>>> /root/jakartaeetck/bin/xml/../../dist/com/sun/ts/tests/samples/ejb/ee/simpleHello/ts_dep/ejb_sam_HelloClient.jar
>>>
>>>
>>> I think that we need to understand why the EJB stubs jar is not being
>>> generated and which code exactly should be generating the EJB stubs jar.
>>>
>>> I'll look for more clues in the git differences between 8.0.2 + master.
>>
>> Looks like we need to invoke the GlassFish admin get-client-stubs [1]
>> to generate the EJB stub classes in
>> dist/com/sun/ts/tests/samples/ejb/ee/simpleHello/ts_dep/ejb_sam_HelloClient.jar.
>>
>> We previously used to invoke
>> org.glassfish.deployment.client.DeploymentFacility.getClientStubs(String
>> location, String moduleID), which internally seems to use
>> get-client-stubs [1].
>>
>> I think that we need to update
>> jakartaee-tck/bin/xml/impl/glassfish/deploy.xml to generate the stubs
>> with [1], as we previously did via
>> org.glassfish.deployment.client.DeploymentFacility.getClientStubs().
>>
>> To do this, we need to update
>> com.sun.ts.lib.implementation.sun.javaee.glassfish.AutoDeployment.deploy(DeploymentInfo
>> info) to either pass enough information on the -deploy ant call or add
>> a new ant call for generating the stubs.
>
> Ok, so I guess we need to invoke the get-client-stubs from the commented
> line "//df.getClientStubs.." at [2] since we have the required
> information at this point.
>
> I will check how to implement this.

Note that the deploy() method is already calling ant with "-deploy" via
[3], which is an example that could be followed (perhaps we could inline
the getClientClassPath method or have it return the needed information
to its caller (deploy()).

Thanks for making the change for this!
Scott


[3]
https://github.com/eclipse-ee4j/jakartaee-tck/blob/bd34dd8e2be27472e1d351746eda21eac5e6748d/src/com/sun/ts/lib/implementation/sun/javaee/glassfish/AutoDeployment.java#L202

>
> [2]
> https://github.com/eclipse-ee4j/jakartaee-tck/blob/bd34dd8e2be27472e1d351746eda21eac5e6748d/src/com/sun/ts/lib/implementation/sun/javaee/glassfish/AutoDeployment.java#L641
>
>
>>
>> Make sense?
>>
>> Scott
>>
>> [1]
>> https://eclipse-ee4j.github.io/glassfish/docs/latest/reference-manual/get-client-stubs.html
>>
>> _______________________________________________
>> jakartaee-tck-dev mailing list
>> jakartaee-tck-dev@xxxxxxxxxxx
>> To unsubscribe from this list, visit
>> https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev



--


--


--


--


--
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com

Back to the top