Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [incquery-dev] Jenkins build is still unstable: EMF-IncQuery Testing - School Tests #785
It seems that indeed, the queryModTest is the culprit:

1. It adds aStudent and bStudent to the aStudent's friendsWith list
2. In the finally block, the undo executes, but the change of the transaction is null, so nothing happens.
3. Every test that comes _after_ queryModTest will see a different model than it would otherwise.
4. The two failing tests are the only ones that make assertions on the size of aStudents friendsWith list size (by inverse traversing it due to the selfloop).

I don't know why the commands are not undone. -- Edit: now we know, as Tamás wrote, the editing domain was incorrect. I tried fixing it with changing from RecordingCommand to AddCommand, which also fixed the issue.

Another minor suggestion: the second part of the assertion in line 101-102 in the queryModTest should be contains(bStudent).

Cheers,
  Ábel Hegedüs

Fault Tolerant Systems Research Group
Department of Measurement and Information Systems
Budapest University of Technology and Economics

On 2013.11.05. 10:43:38, Ábel Hegedüs <abel.hegedus@xxxxxxxxxx> wrote:

On my machine, the DynamicTransitiveClosureHelperTest.queryModTest fails on its own with the following exceptions:
https://gist.github.com/abelhegedus/7315804

However, what is really scary is the following:
1. Running "all tests in project" gets 3 of the tests failing (see other points)
2. Running the test suite (both with or without QRM) on it's own results in no failures
3. Running MixedDynamicInverseReferenceTest.valueAndReferencesTest fails with an NPE on line 71
4. Running DynamicInverseReferenceTest.valueAndReferencesTest by itself passes (but it fails when running all tests).

There seems to be some kind of coupling between the test cases, but I'll leave it to you to dig further.

Cheers,
  Ábel Hegedüs

Fault Tolerant Systems Research Group
Department of Measurement and Information Systems
Budapest University of Technology and Economics

On 2013.11.04. 20:49:46, Tamás Szabó <tamas.szabo@xxxxxxxxx> wrote:

The QRM related test cases are not added to the test suite. If I add
them then I have 130 test cases (which is exactly the same amount that
Jenkins shows).
If I run the suite this way I get a full-green, if I run the "whole
plugin" then I have 260 test cases because the suite is also executed
and this way all tests will be evaluated twice . In the latter case I
also get some failures. However, if I omit the suite from this run (then
again I have 130 test cases) then I get a full-green.

2013.11.04. 16:12 keltezéssel, Ujhelyi Zoltán írta:
> Hi,
>
> as we have tested it with Ábel, the Test suite itself does not contain all tests from the project. Try to execute all tests from the project in one go (the build job does exactly the same).
>
> Cheers,
> Zoli
> -- Zoltán Ujhelyi
> https://www.inf.mit.bme.hu/en/members/ujhelyiz
>
> Fault Tolerant Systems Research Group
> Budapest University of Technology and Economics
>
> On 2013.11.04., at 15:38, Tamás Szabó wrote:
>
>> I am on HEAD of master from EMF-IncQuery-Examples.
>> I was running all the tests (IncQueryBaseTestSuite) and all of the results are green for me.
>>
>> 2013.11.04. 15:12 keltezéssel, Ujhelyi Zoltán írta:
>>> Hi,
>>>
>>> first, our internal build server (https://build.inf.mit.bme.hu/jenkins) still fails with the School tests: https://build.inf.mit.bme.hu/jenkins/job/EMF-IncQuery-Tests-School/
>>>
>>> In my workspace, if I tried to execute all tests of the incquery.runtime.base.test, some failed (consistently), but if I tried to execute the failed tests only by themselves, they were working as expected. This is why I am thinking another test fails to clean up, but had no time to find out which one.
>>>
>>> Cheers,
>>> Zoli
>>> -- Zoltán Ujhelyi
>>> https://www.inf.mit.bme.hu/en/members/ujhelyiz
>>>
>>> Fault Tolerant Systems Research Group
>>> Budapest University of Technology and Economics
>>>
>>> On 2013.11.04., at 15:05, Tamás Szabó wrote:
>>>
>>>> Hi
>>>>
>>>> I have now checked out the test plugin to take a look at the failing tests, but for me everything is green (??).
>>>> @Zoli: how can I reproduce the issue with EMF transaction handling which you mentioned last week?
>>>>
>>>> Cheers,
>>>> Tamas
>>>>
>>>> 2013.11.04. 14:12 keltezéssel, Jenkins Build írta:
>>>>> See
>>>>>
>>>>> _______________________________________________
>>>>> incquery-dev mailing list
>>>>> incquery-dev@xxxxxxxxxxx
>>>>> https://dev.eclipse.org/mailman/listinfo/incquery-dev
>>>> --
>>>> Tamas Szabo
>>>> Software engineer
>>>>
>>>> Tel.: +49 711 342 191 0
>>>> Fax.: +49 711 342 191 29
>>>> Mobil: +49 171 565 416 9
>>>> Web: www.itemis.de
>>>> Mail: tamas.szabo@xxxxxxxxx
>>>> Skype: szabta89
>>>>
>>>> itemis AG
>>>> Niederlassung Süd
>>>> Meitnerstr. 10
>>>> 70563 Stuttgart
>>>>
>>>> Rechtlicher Hinweis:
>>>> Registergericht: Amtsgericht Dortmund HRB 20621 | Sitz der Gesellschaft:
>>>> Lünen
>>>> Vorstand: Jens Wagener (Vorsitzender) | Wolfgang Neuhaus | Dr. Georg
>>>> Pietrek | Jens Trompeter | Sebastian Neus
>>>> Aufsichtsrat: Prof. Dr. Burkhard Igel (Vorsitzender) | Stephan Grollmann
>>>> | Michael Neuhaus
>>>>
>>>> _______________________________________________
>>>> incquery-dev mailing list
>>>> incquery-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/incquery-dev
>>> _______________________________________________
>>> incquery-dev mailing list
>>> incquery-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/incquery-dev
>> --
>> Tamas Szabo
>> Software engineer
>>
>> Tel.: +49 711 342 191 0
>> Fax.: +49 711 342 191 29
>> Mobil: +49 171 565 416 9
>> Web: www.itemis.de
>> Mail: tamas.szabo@xxxxxxxxx
>> Skype: szabta89
>>
>> itemis AG
>> Niederlassung Süd
>> Meitnerstr. 10
>> 70563 Stuttgart
>>
>> Rechtlicher Hinweis:
>> Registergericht: Amtsgericht Dortmund HRB 20621 | Sitz der Gesellschaft:
>> Lünen
>> Vorstand: Jens Wagener (Vorsitzender) | Wolfgang Neuhaus | Dr. Georg
>> Pietrek | Jens Trompeter | Sebastian Neus
>> Aufsichtsrat: Prof. Dr. Burkhard Igel (Vorsitzender) | Stephan Grollmann
>> | Michael Neuhaus
>>
>> _______________________________________________
>> incquery-dev mailing list
>> incquery-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/incquery-dev
> _______________________________________________
> incquery-dev mailing list
> incquery-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/incquery-dev

--
Tamas Szabo
Software engineer

Tel.: +49 711 342 191 0
Fax.: +49 711 342 191 29
Mobil: +49 171 565 416 9
Web: www.itemis.de
Mail: tamas.szabo@xxxxxxxxx
Skype: szabta89

itemis AG
Niederlassung Süd
Meitnerstr. 10
70563 Stuttgart

Rechtlicher Hinweis:
Registergericht: Amtsgericht Dortmund HRB 20621 | Sitz der Gesellschaft:
Lünen
Vorstand: Jens Wagener (Vorsitzender) | Wolfgang Neuhaus | Dr. Georg
Pietrek | Jens Trompeter | Sebastian Neus
Aufsichtsrat: Prof. Dr. Burkhard Igel (Vorsitzender) | Stephan Grollmann
| Michael Neuhaus

_______________________________________________
incquery-dev mailing list
incquery-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/incquery-dev

Back to the top