| Re: [hono-dev] Metrics for processing command responses |
On Wed, 2019-01-09 at 10:08 +0100, Jens Reimann wrote:
> In general I like the idea.
>
> I'm just wondering, why no use "hono.messages" / type="command" for commands?
>
In Hono we stress out the difference between Telemetry traffic (i.e. telemetry
data and events) flowing from devices to applications on the one hand and Command
& Control traffic on the other hand, flowing from applications to devices. based
on that distinction, using a single metric for counting all messages is not
really useful because we will be only interested in the number of telemetry &
event messages flowing downstream vs. the number of commands flowing upstream.
The Micrometer (to me) suggests that if the value of a metric is only meaningful
when drilling further down (using one or more dimensions/tags) then the you
should use different metric names in the first place. This is why using separate
metric names for metering Telemetry & Event vs. Command & Control makes sense to
me.
> Also what looks a bit strange to me us that the one metric is named
> "hono.messages", and the other "hono.messages.payload", … maybe "hono.payload",
> or "hono.messages.count" would make more sense?! But that is just a matter of
> style, less of functionality.
I agree that using "hono.messages.count" and "hono.messages.payloadsize" would
make even more sense (and "hono.commands.count" and "hono.commands.payload" for
C&C).
>
> On Tue, Jan 8, 2019 at 5:53 PM Hudalla Kai (INST/ECS4) <
> kai.hudalla@xxxxxxxxxxxx> wrote:
> > I have read through the Micrometer documentation again. Based on the
> > recommendations for naming tags [1], I am no longer sure that we are on the
> > right
> > track. Using the same metric name for tracking all types of messages
> > (telemetry,
> > event, command one-way, command request, command response) doesn't feel right
> > to
> > me anymore. FMPOV the aggregated value of "hono.messages.processed" doesn't
> > make
> > any sense without further drilling down, don't you think?
> >
> > based on the advice from the docs, it seems more reasonable to me to use
> > something like
> >
> > Telemetry metrics:
> >
> > "hono.messages", type = "telemetry"
> > status = "processed" / "undeliverable"
> > ttd = "none" / "expired" / "command"
> > "hono.messages.payload", type = "telemetry"
> >
> > Event metrics:
> >
> > "hono.messages", type = "event"
> > status = "processed" / "undeliverable"
> > ttd = "none" / "expired" / "command"
> > "hono.messages.payload" type
> > = "event"
> >
> >
> > Command metrics:
> >
> > "hono.command", direction = "one-way" / "request" / "response"
> > status = "processed" / "undeliverable"
> > "hono.command.payload" direction = "one-way" / "request" / "response"
> >
> > WDYT?
> >
> > [1] https://micrometer.io/docs/concepts#_tag_naming
> >
> >
> > On Wed, 2018-12-12 at 10:16 +0000, Kalidass Kartheeswaran (INST/ECS4) wrote:
> > > Thanks for the valuable feedbacks which shaped the below metrics. I will
> > create
> > > an issue in Github for these metrics.
> > >
> > > one-way command: "hono.messages.processed" type = "command", direction =
> > > "one-way"
> > > command request message: "hono.messages.processed" type = "command",
> > direction
> > > = "request"
> > > command response message: "hono.messages.processed" type = "command",
> > > direction = "response"
> > >
> > > command payload metrics:
> > > ------------------------------------
> > > one-way command: "hono.messages.processed.payload" type = "command",
> > > direction = "one-way"
> > > command request message: " hono.messages.processed.payload" type =
> > "command",
> > > direction = "request"
> > > command response message: " hono.messages.processed.payload" type =
> > "command",
> > > direction = "response"
> > >
> > >
> > > Mit freundlichen Grüßen / Best Regards
> > >
> > > Kartheeswaran Kalidass
> > >
> > >
> > _______________________________________________
> > hono-dev mailing list
> > hono-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or unsubscribe from
> > this list, visit
> > https://www.eclipse.org/mailman/listinfo/hono-dev
>
>
> _______________________________________________
> hono-dev mailing list
> hono-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://www.eclipse.org/mailman/listinfo/hono-dev
_______________________________________________
hono-dev mailing list
hono-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/hono-dev