| [hono-dev] Metrics for processing command responses |
|
Dear Hono community, Currently I work on the implementation of metrics for the AMQP adapter and thanks Kai for bringing to notice about the metric "hono.commands.response.delivered".
This metric is currently being used only to track the number of command responses processed by the protocol adapters. There is an already existing metric "hono.messages.processed", which tracks the number of successfully processed messages by
the protocol adapters. The telemetry messages are tracked with type as "telemetry" and so the events. This metric "hono.messages.processed" with type "command" is better suited also to track the number of command responses.
FMPOV, in addition to the count, the payload size of command responses can also be tracked by using the metric "hono.messages.processed.payload". Currently no metrics keep track of the payload size of command responses. Hence I would propose the below: 1. use the metric "hono.messages.processed" (with type "command") to track the number of successfully processed command responses and drop the metric
"hono.commands.response.delivered" from Hono. 2. use the metric "hono.messages.processed.payload" (with type "command") to track the payload size of the successfully processed command responses. WDYT? Mit freundlichen Grüßen / Best regards
|