[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [ee4j-pmc] [ee4j-build] EE4J Parent pom.xml update
|
Don’t feel troubled contacting me. :) It’s part of my job to do it and I’m totally fine (and even encourage you) doing it this way.
I understand the problem. It happens than projects are not healthy. It indicates that committers and project leads are not interesting in projects and not doing their job well. The problem is not in branch protection. The problem is that people are not responding. With branch protection on, all PRs are visible and committers are free to approve or reject them. Code review is definitely a good practice. Possibly you don’t realise how many bad code were fixed during the review process. Reviews must be required for all committers or completely disabled. I am voting against direct commits. It may add other kind of problems. Also, please remember that EE4J_8 branch protection is added to filter out all changes except critical bug fixes
— Dmitry.
> On 2 Nov 2018, at 18:48, Bill Shannon <bill.shannon@xxxxxxxxxx> wrote:
>
> arjan tijms wrote on 11/02/2018 10:08 AM:
>>
>> [small rant]
>> It might be helpful if the branch protected for EE4J branches, at least for selected people working on the jobs, is temporarily removed. I'm not sure how everyone else feels about this, but I'm not particularly happy with all the begging that needs to be done to get a PR merged. Dmitry for instance has been an extremely good help here, but I do feel somewhat troubled sending him mails all the time. Other committers in the projects likely don't even see the PR review requests. I often ask a review from the full group of 15 people (the max on GitHub), and just nobody responds.
>>
> I completely agree!
>
> I think we should allow at least Project Leads, and maybe all Committers, to decide which changes need to be reviewed by others and which changes can be committed directly.
>
> _______________________________________________
> ee4j-build mailing list
> ee4j-build@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/ee4j-build
