[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [jsonp-dev] [External] : Re: : JsonProvider.JSONP_PROVIDER_FACTORY potential breaking change in JSON-P 2.1?
|
- From: Lukas Jungmann <lukas.jungmann@xxxxxxxxxx>
- Date: Mon, 28 Feb 2022 15:55:31 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bZiOMlSWPDXnIpd4If/l3B2MOi8WH4wYJZZxDolwkOI=; b=e+KLaBJmjOG4tq7mX2R8XcGOe2cgxSs9Cr+UxxMzzCd7lPeg8Z7uM61JmQyfiE7XMHnA2ctYXvZx1ZpJDW3u1SJg8q5igDs6lzRC7uBV4cwbDMjtOj4T25AxUIEYg3U0O5KaenBxqTmx9J6OIY/0fjN39ERLSccEgVhY8KN9jofohYh2SCqK3qhnPFM9OvkU8febCj5JY+OPeMCWNn5GovJJW+/ixKr6M2v3OStdhQEL+dpkkh30mhH4tE6IGgZc+gNC7YMbgvqu5Q1o0cA8vBwt9tZTYMTX8DdU1PEvF6OFLw7g0RMRv2BylgUWb75bfAOZNaq19G2N1WOm5fQHbQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N/UOaL7Upvz54OUV0PYUlTCnZvgZDxoE9AketQYnnXqiyKU0X+EZK17nhaE3gjbIpmKVIXgCzMafQUWmoD4nwYt/Sff1MQG5aCoNxH9v7oxQUaRD6mnLLbKwON1DNZCoWQW4aZJwJE6dpG1SEkUrRrNPhOjZMcjMl9WozQ0uM0abdmkW2Unzei1NoF2Csvxp/MinS1NNp+hAWwLbM833MZPEUbdiHMWBupRgAd1QOFiWCq++CPZu1yaHRr5rhQX3ZhcRluLk235RsjmeX+Ht7BpRTXOm2H0cCPTz7gF+ocJdU4aadelGAlOlOU6FYwj75YAwTRxBmPKE/lukrPU3Bg==
- Delivered-to: jsonp-dev@xxxxxxxxxxx
- List-archive: <https://www.eclipse.org/mailman/private/jsonp-dev/>
- List-help: <mailto:jsonp-dev-request@eclipse.org?subject=help>
- List-subscribe: <https://www.eclipse.org/mailman/listinfo/jsonp-dev>, <mailto:jsonp-dev-request@eclipse.org?subject=subscribe>
- List-unsubscribe: <https://www.eclipse.org/mailman/options/jsonp-dev>, <mailto:jsonp-dev-request@eclipse.org?subject=unsubscribe>
- User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1
On 2/26/22 4:18 PM, Nathan Rauh wrote:
Lukas,
Sorry for only linking to the source location - that seemed the most convenient to identify the exact location of what I was referring to but didn't illustrate what the JavaDoc looks like. Yes, @value does show the actual value in the text, but that text is rendered as a link to the constant, which doesn't go anywhere after being switched from public to private. The JavaDoc HTML looks like this:
'If the system property <a href="#JSONP_PROVIDER_FACTORY">"jakarta.json.provider"</a> exists, then its value is assumed to be the provider factory class.'
ah, so was about broken link. Well, when I provided fix for few hundreds
of them, nobody cared and it is unlikely someone will ever will (see
https://github.com/jakartaee/specifications/pull/346)
regards,
--lukas
That said, I noticed you've already gotten it fixed under https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jsonp/pull/365__;!!ACWV5N9M2RV99hQ!fYBMJdzpwTYQa4NXv3lIFgQqr0G7D-8LogYOVZFs2Zpqnhunt9lW6Dr50uD1QAtqgFQ$ and the new JavaDoc under https://urldefense.com/v3/__https://jakarta.oss.sonatype.org/content/groups/staging/jakarta/json/jakarta.json-api/2.1.0/__;!!ACWV5N9M2RV99hQ!fYBMJdzpwTYQa4NXv3lIFgQqr0G7D-8LogYOVZFs2Zpqnhunt9lW6Dr50uD1NP_vy2I$ dated today looks good with the link working again. Thanks!
On 2/26/22, 2:30 AM, "jsonp-dev on behalf of Lukas Jungmann" <jsonp-dev-bounces@xxxxxxxxxxx on behalf of lukas.jungmann@xxxxxxxxxx> wrote:
Hi,
On 2/25/22 6:25 PM, Nathan Rauh wrote:
> Hi,
>
> While trying to identify what is new in EE 10 for JSON-P,
there are multiple ways to easily (I hope!) find that out before the
release gets published:
release record:
https://urldefense.com/v3/__https://projects.eclipse.org/projects/ee4j.jsonp/releases/2.1__;!!ACWV5N9M2RV99hQ!fYBMJdzpwTYQa4NXv3lIFgQqr0G7D-8LogYOVZFs2Zpqnhunt9lW6Dr50uD1SYpqtWI$
spec index page (through the spec pr):
https://urldefense.com/v3/__https://github.com/jakartaee/specifications/pull/432__;!!ACWV5N9M2RV99hQ!fYBMJdzpwTYQa4NXv3lIFgQqr0G7D-8LogYOVZFs2Zpqnhunt9lW6Dr50uD1LNtFaq8$
project on GH: https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jsonp/projects/1__;!!ACWV5N9M2RV99hQ!fYBMJdzpwTYQa4NXv3lIFgQqr0G7D-8LogYOVZFs2Zpqnhunt9lW6Dr50uD1LBMQkxU$
and lastly the diff:
https://urldefense.com/v3/__https://github.com/eclipse-ee4j/jsonp/compare/2.0.0...2.1.0-RELEASE__;!!ACWV5N9M2RV99hQ!fYBMJdzpwTYQa4NXv3lIFgQqr0G7D-8LogYOVZFs2Zpqnhunt9lW6Dr50uD1jaoGKxs$
> However, the switch to from public to private visibility seems like a
> mistake given that it continues to be referenced from public JavaDoc
> within the same class,
@value uses the actual value of the constant being referenced, see the
documentation/man of javadoc for more details on this. Or have you
found the constant name anywhere in the _generated_ javadoc and not just
in sources?
but yes, I see no problem in moving the constant back to public, even
though I believe that the real impact of this change is rather limited
(close to zero)
thanks,
--lukas
_______________________________________________
jsonp-dev mailing list
jsonp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jsonp-dev__;!!ACWV5N9M2RV99hQ!fYBMJdzpwTYQa4NXv3lIFgQqr0G7D-8LogYOVZFs2Zpqnhunt9lW6Dr50uD1vW50CNA$
_______________________________________________
jsonp-dev mailing list
jsonp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jsonp-dev__;!!ACWV5N9M2RV99hQ!fYBMJdzpwTYQa4NXv3lIFgQqr0G7D-8LogYOVZFs2Zpqnhunt9lW6Dr50uD1vW50CNA$