Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[jsonp-dev] JsonProvider.JSONP_PROVIDER_FACTORY potential breaking change in JSON-P 2.1?
  • From: Nathan Rauh <nathan.rauh@xxxxxxxxxx>
  • Date: Fri, 25 Feb 2022 17:25:46 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=us.ibm.com; dmarc=pass action=none header.from=us.ibm.com; dkim=pass header.d=us.ibm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ktBxideWSXFEnr8LSAxrTpucjBN/wyK3KnB6/+qcOPg=; b=XQON5tzMQ7Z4Bqe3DWBQQZT8EXuuLM4VP01j8DzgPZfpX9f9Xgthfgwzhp7jYULmP3U6Y/ZlKTLdt4UZLmwJMIX1cYh2LFUNGqtV6UNkp38gRRWXs448zW+49cdtzXXySEZNjDw2Gk72VzUMoEIQDj0Grj+r5C9Mlj+KJ44kjjsJ6FsjO+EaTv8l4HXCkZXzUR+W6StrbHSnr+BQ4LvO7JayEu88amucGS0g8dLGqbRFZD3D51hHSzWf9RB1M8beJ5gLe9isIK6s79NDFHwo5oJa+t0p/MW0wR+EUGpMB371c+U/Qut0JZPh+4bouLcV90oiHbDK6WU9fx7HWXOrJw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AXK0kAL4hZUXqKXv+WrC4hcfqRDy9hCV4tEccHwXGhyoBWuge0bfOlb+xef6+Q5PrkaUF3WDjuUpehXwOu+O+TkqqGh/laW9ACW8t+KtGUAFOsonoWBJS6SB5g4xVuMSmcYXZUIVv8MPUIimocj/AukeGfRWfXbGtlK3WB9/E/UPtEIYkol2nLHknPdyB3cUUpThFPM+nP1OdbzSwGWvHHAZ9OJkjpbLwmWbRp/vzpOiyOcFFoxpF4j1H9K67iThONt7HeGsYc/topvskbdMwvSU0xtOVOD2Z7XuYJjF+S4pAtD+uQnvfMc1AtnOhucb/6rx5WA6cJGLLJvnt9nV2w==
  • Delivered-to: jsonp-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/jsonp-dev/>
  • List-help: <mailto:jsonp-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/jsonp-dev>, <mailto:jsonp-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/jsonp-dev>, <mailto:jsonp-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHYKmy5Ur6AOXUqSkOaSHZXlqL9+w==
  • Thread-topic: JsonProvider.JSONP_PROVIDER_FACTORY potential breaking change in JSON-P 2.1?

Hi,

While trying to identify what is new in EE 10 for JSON-P, I came across the following change/removal of a public constant,

jakarta.json.spi.JsonProvider.JSONP_PROVIDER_FACTORY

and so wanted to confirm that this was intended/valid to do in a point release.

 

It’s in an spi package rather than api, and was documented as a system property name rather than something that application code would directly refer to.

 

However, the switch to from public to private visibility seems like a mistake given that it continues to be referenced from public JavaDoc within the same class,

https://github.com/eclipse-ee4j/jsonp/blob/1d5a2a5ef4746684ff143d3c7f0ac887ef364f49/api/src/main/java/jakarta/json/spi/JsonProvider.java#L88

 

Here’s the commit where it changed,

https://github.com/eclipse-ee4j/jsonp/commit/4323652579edcee6368c9c073b1d1df427fcfd15?diff=unified

 

Does this need to be corrected in 2.1?  Sorry to discover it so late in the release cycle.

Back to the top