[udig-devel] ID use in Layer

[Jody Garnett <jody.garnett@xxxxxxxxx>]

Hi Jesse:

I had a look at your changes to ID (finally!) and removed the  
setQualifier method - the idea is to treat an ID as immutable. I have  
added additional constructors to allow the qualifier to be specified  
during creation.

I had test failures in IDTest (since hashcode does not exactly match  
the toString representation anymore).

I was a bit worried about the use of ID in the LayerImpl: There is a  
bunch of logic there (to lazily create an ID from a URL); it was not  
completely filling in all the ID fields (such as URI) which kind of  
breaks the contract. Can this logic be moved into the ID constructor  
for new ID( URL ) ?

ToString has no representation of the qualifier; could we add this to  
the string representation and adjust the constructors to match?

Jody