Wyatt,
I suggest that we get the plugins sorted out now. i.e. work out which classes you want to be API and which not, and moving these to an appropriate package. Just exporting the whole of a .internal package is not going to work.
I reduced visibility in the last checkin, so if this is not correct we need to work out what is.
Greg
On Aug 9, 2011, at 12:42 PM, Wyatt Spear wrote: This package is relied on by several other ETFW plugins and potentially other plugins that use its extension points. I suppose I could disable non-ptp launch functionality altogether in 5.0.x and just keep the fix in Head.
=Wyatt On Sun, Aug 7, 2011 at 6:12 AM, Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
Wyatt,
Does the package need to be exported? I think it would be ok to un-export it, then create an exception because the package was incorrectly exported.
Greg On Aug 6, 2011, at 11:38 AM, Wyatt Spear wrote: This is a pretty major bug fix, actually. I don't know how long it has been the case, since I rarely use the non-parallel etfw launch, but the launcher couldn't load it until I made it public. Otherwise it just gave OSGI errors.
I'll revert if necessary but without this change this part of the plugin is pretty much non-functional.
=Wyatt On Sat, Aug 6, 2011 at 6:59 AM, Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
Wyatt,
Access to the ToolLaunchConfigurationDelegate class has been changed from package to public. Unfortunately the package containing this class is marked as exported, so this constitutes an API change.
You'll need to revert this change.
Thanks, Greg On Aug 5, 2011, at 2:50 PM, Wyatt Spear wrote:
I just committed a since tag to that class. I'm not sure why I didn't see that error over here though...
=Wyatt On Fri, Aug 5, 2011 at 11:33 AM, Albert L. Rossi <arossi@xxxxxxxxxxxxx> wrote:
Hi,
on my latest update of PTP 5_0, I am now getting the following errors:
Missing @since tag on org.eclipse.ptp.etfw.internal.ToolLaunchConfigurationDelegate ToolLaunchConfigurationDelegate.java /org.eclipse.ptp.etfw/src/org/eclipse/ptp/etfw/internal line 35 @since tag problem
The minor version should be incremented in version 4.0.0, since new APIs have been added since version 4.0.0 MANIFEST.MF /org.eclipse.ptp.etfw/META-INF line 5 Version Numbering Problem
Al
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev
_______________________________________________ ptp-dev mailing list ptp-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/ptp-dev
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev
_______________________________________________ ptp-dev mailing list ptp-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/ptp-dev
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev
_______________________________________________ ptp-dev mailing list ptp-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/ptp-dev
|