Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ptp-dev] PTP code formatter - comments formatting
I think that those 3 changes clearly improve the current profile.

I uploaded the originally profile because none existed. I tried to make the profile reflect our coding standard from the wiki. But not all settings in the profile are explicitly stated in the coding standard. Thus if anyone has further suggestions to improve the profile please go ahead. All setting not in the coding standard the profile is just meant as my suggestion.

Roland

On Mon, Apr 25, 2011 at 10:49 AM, Beth Tibbitts <tibbitts@xxxxxxxxxx> wrote:

Any problems with my adding this change to the PTP formatter profile? I don't think this would change any existing code that has been formatted with the existing one.
It's a change only to comment formmating (actually, doing less of it.)




...Beth

Beth Tibbitts
Eclipse Parallel Tools Platform http://eclipse.org/ptp
IBM STG - High Performance Computing Tools
Mailing Address: IBM Corp., 745 West New Circle Road, Lexington, KY 40511

Inactive hide details for "Jay Alameda" ---04/19/2011 03:45:14 PM---Beth,"Jay Alameda" ---04/19/2011 03:45:14 PM---Beth,


    From:

"Jay Alameda" <jalameda@xxxxxxxxxxxxxxxxx>

    To:

"'Parallel Tools Platform general developers'" <ptp-dev@xxxxxxxxxxx>

    Date:

04/19/2011 03:45 PM

    Subject:

Re: [ptp-dev] PTP code formatter - comments formatting

    Sent by:

ptp-dev-bounces@xxxxxxxxxxx



Beth,

80 characters sounds so, um, Fortran-esque!. I’m trying to imagine living within these bounds, having a hard time with that…

Jay


From: ptp-dev-bounces@xxxxxxxxxxx [mailto:ptp-dev-bounces@xxxxxxxxxxx] On Behalf Of Beth Tibbitts
Sent: Tuesday, April 19, 2011 1:44 PM
To: ptp-dev@xxxxxxxxxxx
Subject: [ptp-dev] PTP code formatter - comments formatting

I'm finally getting around to applying the PTP code formatting template on some PLDT source files.
(Ref: On the wiki under developer guidelines: http://wiki.eclipse.org/PTP/policy/developer_guidelines#PTP_formatting_and_cleanup_profiles_for_Java )
See Eclipse Preferences > Java > Code Style > Formatter

It does more mashing of comments and block comments than I'd like.
The line length for comments was set to 80, where the line length for code is 132.

I would like to propose, on the Comments tab of the Profile editor under Preferences > Java > Code Style > Formatter
1) set comment line length to 132 to match code line length
2) check "Never join lines" so it won't wrap existing comment lines
3) enable @formatting:on and @formatting:off in comments, so that the block comments that have been carefully formatted won't be munged. I don't need these in very many places but it's nice to be able to turn it on when you do.

Comments? I don't think this change will change any existing comments from the old profile.




...Beth

Beth Tibbitts
Eclipse Parallel Tools Platform http://eclipse.org/ptp

IBM STG - High Performance Computing Tools
Mailing Address: IBM Corp., 745 West New Circle Road, Lexington, KY 40511_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev


_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev




--
ORNL/UT Center for Molecular Biophysics cmb.ornl.gov
865-241-1537, ORNL PO BOX 2008 MS6309

Back to the top