Re: [ptp-dev] rdt.sync.ui

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [ptp-dev] rdt.sync.ui

From: Roland Schulz <roland@xxxxxxx>
Date: Fri, 14 Jan 2011 08:32:02 -0500
Delivered-to: ptp-dev@xxxxxxxxxxx
Domainkey-signature: a=rsa-sha1; c=nofws; d=rschulz.eu; s=google; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type; b=M+lKxk0aP9WubVHPQnzR1/lrh1ax4h5Bsya3oW2BBcfrzGgpYtok62j5XIrdLKVpro kYrrX8ah92ixL9DFVlM9WFzcMU4jvtYYynUgRr/mqdDvLU3/HI7qgHdDdZWQFFE8ur59 As2MOiqm3PijYyG67oQ1yoTsUNSROo+Iur2RY=
List-archive: <https://dev.eclipse.org/mailman/private/ptp-dev>
List-help: <mailto:ptp-dev-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/ptp-dev>, <mailto:ptp-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/options/ptp-dev>, <mailto:ptp-dev-request@eclipse.org?subject=unsubscribe>

I think these are introduced by Greg's commit "Rename legacy interface to match IP* hierarchy"

Is it OK to just add all missing since tags?

On Thu, Jan 13, 2011 at 12:54 PM, Albert L. Rossi <arossi@xxxxxxxxxxxxx> wrote:

Then Roland is right: there are a lot of @since tags missing.

----- Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
> 4.0.0 baseline should also be set on HEAD so that you see API changes since this version.
>
> Greg
>
> On Jan 13, 2011, at 12:03 PM, Albert L. Rossi wrote:
>
> > The 4.0.0 baseline should not be set on HEAD, right? Only on the tagged 4.0 version. Or did I misunderstand?
> >
> > ----- Roland Schulz <roland@xxxxxxx> wrote:
> >> Hi,
> >>
> >> I get the same error.
> >>
> >> Additional I get the following API errors. Should one still use 4.0.0 as
> >> baseline?
> >>
> >> Description Resource Path Location Type
> >> Missing @since tag on canSave(Control, IPResourceManager, IPQueue)
> >> ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 59 @since tag
> >> problem
> >> Missing @since tag on createControl(Composite, IPResourceManager, IPQueue)
> >> AdvancedMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 136 @since tag problem
> >> Missing @since tag on createControl(Composite, IPResourceManager, IPQueue)
> >> AdvancedOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 231 @since tag problem
> >> Missing @since tag on createControl(Composite, IPResourceManager, IPQueue)
> >> BasicMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 262 @since tag problem
> >> Missing @since tag on createControl(Composite, IPResourceManager, IPQueue)
> >> BasicOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 317 @since tag problem
> >> Missing @since tag on createControl(Composite, IPResourceManager, IPQueue)
> >> ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 77 @since tag
> >> problem
> >> Missing @since tag on getAttributes(IPResourceManager, IPQueue,
> >> ILaunchConfiguration, String)
> >> AdvancedMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 162 @since tag problem
> >> Missing @since tag on getAttributes(IPResourceManager, IPQueue,
> >> ILaunchConfiguration, String)
> >> AdvancedOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 434 @since tag problem
> >> Missing @since tag on getAttributes(IPResourceManager, IPQueue,
> >> ILaunchConfiguration, String)
> >> BasicMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 330 @since tag problem
> >> Missing @since tag on getAttributes(IPResourceManager, IPQueue,
> >> ILaunchConfiguration, String)
> >> BasicOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 398 @since tag problem
> >> Missing @since tag on getAttributes(IPResourceManager, IPQueue,
> >> ILaunchConfiguration, String) ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 103 @since tag
> >> problem
> >> Missing @since tag on getQueueFromName(IPResourceManager, String)
> >> AbstractRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.launch/src/org/eclipse/ptp/launch/ui/extensions line
> >> 116 @since
> >> tag problem
> >> Missing @since tag on getResourceManager()
> >> RMLaunchConfigurationDynamicTabDataSource.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 53 @since tag
> >> problem
> >> Missing @since tag on initializeFrom(Control, IPResourceManager, IPQueue,
> >> ILaunchConfiguration) ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 149 @since tag
> >> problem
> >> Missing @since tag on isValid(ILaunchConfiguration, IPResourceManager,
> >> IPQueue) ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 168 @since tag
> >> problem
> >> Missing @since tag on performApply(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue) ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 186 @since tag
> >> problem
> >> Missing @since tag on setDefaults(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue)
> >> AdvancedMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 181 @since tag problem
> >> Missing @since tag on setDefaults(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue)
> >> AdvancedOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 443 @since tag problem
> >> Missing @since tag on setDefaults(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue) BasicMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 364 @since tag problem
> >> Missing @since tag on setDefaults(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue) BasicOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 422 @since tag problem
> >> Missing @since tag on setDefaults(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue) ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 205 @since tag
> >> problem
> >> Missing @since tag on setResourceManager(IPResourceManager)
> >> RMLaunchConfigurationDynamicTabDataSource.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 49 @since tag
> >> problem
> >>
> >> Roland
> >>
> >>
> >> On Mon, Jan 10, 2011 at 12:09 PM, Albert L. Rossi <arossi@xxxxxxxxxxxxx>wrote:
> >>
> >>> Hi,
> >>>
> >>> I just checked out a fresh copy of HEAD, and noticed an API inconsistency
> >>> in org.eclipse.ptp.rdt.sync.ui
> >>>
> >>> org.eclipse.ptp.internal.rdt.sync.ui.scannerinfo.RemoteIncludeDialog, line
> >>> 175
> >>> org.eclipse.ptp.rdt.sync.ui.wizards.RemoteProjectContentsLocationArea, line
> >>> 244
> >>>
> >>> call a method from org.eclipse.ptp.remote.ui.IRemoteConnection,
> >>> openConnectionWithProgress, whose signature requires
> >>> org.eclipse.jface.operation.IRunnableContext as its second of three
> >>> arguments, but evidently there was a previous version with two arguments,
> >>> and that is the one being called at those points.
> >>>
> >>> Al
> >>> _______________________________________________
> >>> ptp-dev mailing list
> >>> ptp-dev@xxxxxxxxxxx
> >>> https://dev.eclipse.org/mailman/listinfo/ptp-dev
> >>>
> >>>
> >>>
> >>
> >>
> >> --
> >> ORNL/UT Center for Molecular Biophysics cmb.ornl.gov
> >> 865-241-1537, ORNL PO BOX 2008 MS6309
> >
> > _______________________________________________
> > ptp-dev mailing list
> > ptp-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/ptp-dev
>
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ptp-dev
>

_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev

--
ORNL/UT Center for Molecular Biophysics cmb.ornl.gov
865-241-1537, ORNL PO BOX 2008 MS6309

Follow-Ups:
- Re: [ptp-dev] rdt.sync.ui
  - From: Greg Watson

References:
- Re: [ptp-dev] rdt.sync.ui
  - From: Greg Watson
- Re: [ptp-dev] rdt.sync.ui
  - From: Albert L. Rossi

Prev by Date: Re: [ptp-dev] Updated PTP Wiki to add current PE resource manager info
Next by Date: Re: [ptp-dev] Updated PTP Wiki to add current PE resource manager info
Previous by thread: Re: [ptp-dev] rdt.sync.ui
Next by thread: Re: [ptp-dev] rdt.sync.ui
Index(es):
- Date
- Thread

Breadcrumbs