Re: [ptp-dev] rdt.sync.ui

["Albert L. Rossi" <arossi@xxxxxxxxxxxxx>]

Then Roland is right: there are a lot of @since tags missing.


----- Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
> 4.0.0 baseline should also be set on HEAD so that you see API changes since this version.
> 
> Greg
> 
> On Jan 13, 2011, at 12:03 PM, Albert L. Rossi wrote:
> 
> > The 4.0.0 baseline should not be set on HEAD, right?  Only on the tagged 4.0 version.  Or did I misunderstand?
> > 
> > ----- Roland Schulz <roland@xxxxxxx> wrote:
> >> Hi,
> >> 
> >> I get the same error.
> >> 
> >> Additional I get the following API errors. Should one still use 4.0.0 as
> >> baseline?
> >> 
> >> Description Resource Path Location Type
> >> Missing @since tag on canSave(Control, IPResourceManager, IPQueue)
> >> ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 59 @since tag
> >> problem
> >> Missing @since tag on createControl(Composite, IPResourceManager, IPQueue)
> >> AdvancedMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 136 @since tag problem
> >> Missing @since tag on createControl(Composite, IPResourceManager, IPQueue)
> >> AdvancedOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 231 @since tag problem
> >> Missing @since tag on createControl(Composite, IPResourceManager, IPQueue)
> >> BasicMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 262 @since tag problem
> >> Missing @since tag on createControl(Composite, IPResourceManager, IPQueue)
> >> BasicOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 317 @since tag problem
> >> Missing @since tag on createControl(Composite, IPResourceManager, IPQueue)
> >> ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 77 @since tag
> >> problem
> >> Missing @since tag on getAttributes(IPResourceManager, IPQueue,
> >> ILaunchConfiguration, String)
> >> AdvancedMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 162 @since tag problem
> >> Missing @since tag on getAttributes(IPResourceManager, IPQueue,
> >> ILaunchConfiguration, String)
> >> AdvancedOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 434 @since tag problem
> >> Missing @since tag on getAttributes(IPResourceManager, IPQueue,
> >> ILaunchConfiguration, String)
> >> BasicMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 330 @since tag problem
> >> Missing @since tag on getAttributes(IPResourceManager, IPQueue,
> >> ILaunchConfiguration, String)
> >> BasicOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 398 @since tag problem
> >> Missing @since tag on getAttributes(IPResourceManager, IPQueue,
> >> ILaunchConfiguration, String) ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 103 @since tag
> >> problem
> >> Missing @since tag on getQueueFromName(IPResourceManager, String)
> >> AbstractRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.launch/src/org/eclipse/ptp/launch/ui/extensions line
> >> 116 @since
> >> tag problem
> >> Missing @since tag on getResourceManager()
> >> RMLaunchConfigurationDynamicTabDataSource.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 53 @since tag
> >> problem
> >> Missing @since tag on initializeFrom(Control, IPResourceManager, IPQueue,
> >> ILaunchConfiguration) ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 149 @since tag
> >> problem
> >> Missing @since tag on isValid(ILaunchConfiguration, IPResourceManager,
> >> IPQueue) ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 168 @since tag
> >> problem
> >> Missing @since tag on performApply(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue) ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 186 @since tag
> >> problem
> >> Missing @since tag on setDefaults(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue)
> >> AdvancedMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 181 @since tag problem
> >> Missing @since tag on setDefaults(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue)
> >> AdvancedOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 443 @since tag problem
> >> Missing @since tag on setDefaults(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue) BasicMPICH2RMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.mpich2.ui/src/org/eclipse/ptp/rm/mpi/mpich2/ui/launch
> >> line
> >> 364 @since tag problem
> >> Missing @since tag on setDefaults(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue) BasicOpenMpiRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.mpi.openmpi.ui/src/org/eclipse/ptp/rm/mpi/openmpi/ui/launch
> >> line
> >> 422 @since tag problem
> >> Missing @since tag on setDefaults(ILaunchConfigurationWorkingCopy,
> >> IPResourceManager, IPQueue) ExtendableRMLaunchConfigurationDynamicTab.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 205 @since tag
> >> problem
> >> Missing @since tag on setResourceManager(IPResourceManager)
> >> RMLaunchConfigurationDynamicTabDataSource.java
> >> /org.eclipse.ptp.rm.ui/src/org/eclipse/ptp/rm/ui/launch line 49 @since tag
> >> problem
> >> 
> >> Roland
> >> 
> >> 
> >> On Mon, Jan 10, 2011 at 12:09 PM, Albert L. Rossi <arossi@xxxxxxxxxxxxx>wrote:
> >> 
> >>> Hi,
> >>> 
> >>> I just checked out a fresh copy of HEAD, and noticed an API inconsistency
> >>> in org.eclipse.ptp.rdt.sync.ui
> >>> 
> >>> org.eclipse.ptp.internal.rdt.sync.ui.scannerinfo.RemoteIncludeDialog, line
> >>> 175
> >>> org.eclipse.ptp.rdt.sync.ui.wizards.RemoteProjectContentsLocationArea, line
> >>> 244
> >>> 
> >>> call a method from org.eclipse.ptp.remote.ui.IRemoteConnection,
> >>> openConnectionWithProgress, whose signature requires
> >>> org.eclipse.jface.operation.IRunnableContext as its second of three
> >>> arguments, but evidently there was a previous version with two arguments,
> >>> and that is the one being called at those points.
> >>> 
> >>> Al
> >>> _______________________________________________
> >>> ptp-dev mailing list
> >>> ptp-dev@xxxxxxxxxxx
> >>> https://dev.eclipse.org/mailman/listinfo/ptp-dev
> >>> 
> >>> 
> >>> 
> >> 
> >> 
> >> -- 
> >> ORNL/UT Center for Molecular Biophysics cmb.ornl.gov
> >> 865-241-1537, ORNL PO BOX 2008 MS6309
> > 
> > _______________________________________________
> > ptp-dev mailing list
> > ptp-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/ptp-dev
> 
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ptp-dev
>