[ptp-dev] org.eclipse.ptp.rm.remote broken in HEAD

[Igor Peshansky <igorp@xxxxxxxxxx>]

Hi,

I'm getting errors in org.eclipse.ptp.rm.remote when building from CVS 
HEAD:

Description     Resource        Path    Location        Type
The method getResource(String) in the type IRemoteFileManager is not 
applicable for the arguments (Path, IProgressMonitor) 
AbstractRemoteProxyResourceManagerConfigurationWizardPage.java 
/org.eclipse.ptp.rm.remote/src/org/eclipse/ptp/rm/remote/ui/wizards line 
690     Java Problem
The method getResource(String) in the type IRemoteFileManager is not 
applicable for the arguments (Path, SubMonitor) 
AbstractRemoteProxyRuntimeClient.java 
/org.eclipse.ptp.rm.remote/src/org/eclipse/ptp/rm/remote/core   line 183 
Java Problem

I believe these are the result of the recent API changes to 
IRemoteFileManager.  The patch below fixes the build for me.  Is the fix 
correct?
        Igor

### Eclipse Workspace Patch 1.0
#P org.eclipse.ptp.rm.remote
Index: 
src/org/eclipse/ptp/rm/remote/core/AbstractRemoteProxyRuntimeClient.java
===================================================================
RCS file: 
/cvsroot/tools/org.eclipse.ptp/core/org.eclipse.ptp.rm.remote/src/org/eclipse/ptp/rm/remote/core/AbstractRemoteProxyRuntimeClient.java,v
retrieving revision 1.21
diff -u -r1.21 AbstractRemoteProxyRuntimeClient.java
--- 
src/org/eclipse/ptp/rm/remote/core/AbstractRemoteProxyRuntimeClient.java 8 
Sep 2009 15:03:38 -0000 1.21
+++ 
src/org/eclipse/ptp/rm/remote/core/AbstractRemoteProxyRuntimeClient.java 2 
Nov 2009 02:22:02 -0000
@@ -180,7 +180,7 @@
                                        throw new 
IOException(Messages.AbstractRemoteProxyRuntimeClient_9);
                                }
 
-                               IFileStore res = 
fileManager.getResource(new Path(config.getProxyServerPath()), 
subMon.newChild(2));
+                               IFileStore res = 
fileManager.getResource(config.getProxyServerPath());
                                if (!res.fetchInfo().exists()){
                                        throw new 
IOException(NLS.bind(Messages.AbstractRemoteProxyRuntimeClient_12, 
config.getProxyServerPath()));
                                }
Index: 
src/org/eclipse/ptp/rm/remote/ui/wizards/AbstractRemoteProxyResourceManagerConfigurationWizardPage.java
===================================================================
RCS file: 
/cvsroot/tools/org.eclipse.ptp/core/org.eclipse.ptp.rm.remote/src/org/eclipse/ptp/rm/remote/ui/wizards/AbstractRemoteProxyResourceManagerConfigurationWizardPage.java,v
retrieving revision 1.17
diff -u -r1.17 
AbstractRemoteProxyResourceManagerConfigurationWizardPage.java
--- 
src/org/eclipse/ptp/rm/remote/ui/wizards/AbstractRemoteProxyResourceManagerConfigurationWizardPage.java 
16 Oct 2009 18:21:55 -0000      1.17
+++ 
src/org/eclipse/ptp/rm/remote/ui/wizards/AbstractRemoteProxyResourceManagerConfigurationWizardPage.java 
2 Nov 2009 02:22:02 -0000
@@ -687,14 +687,11 @@
 throws InvocationTargetException,
 InterruptedException {
 try {
- IFileStore file = fileMgr.getResource(
-               new Path(path), monitor);
+ IFileStore file = fileMgr.getResource(path);
 if (!monitor.isCanceled()) {
        proxyPathIsValid = file.fetchInfo(
                        EFS.NONE, monitor).exists();
 }
-                                                                       } 
catch (IOException e) {
- throw new InvocationTargetException(e);
                                                                        } 
catch (CoreException e) {
 throw new InvocationTargetException(e);
                                                                        }

-- 
Igor Peshansky  (note the spelling change!)
IBM T.J. Watson Research Center
XJ: No More Pain for XML's Gain (http://www.research.ibm.com/xj/)
X10: Parallel Productivity and Performance (http://x10.sf.net/)