[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [platform-dev] backporting and building?
|
Tony,
From a workspace with everything in it as produced by
https://wiki.eclipse.org/Eclipse_Platform_SDK_Provisioning I can
see two references to org.apache.ant.
https://git.eclipse.org/c/pde/eclipse.pde.build.git/tree/org.eclipse.pde.build/feature/feature.xml
https://git.eclipse.org/c/platform/eclipse.platform.releng.git/tree/features/org.eclipse.platform-feature/feature.xml
If your application requires directly
or indirectly these features, that would restrict the versions to
the specific org.apache.ant version used when these features are
built, and I'm pretty sure this is enforced at runtime, though not
absolutely sure. Certainly any attempts to do p2 updates will not
be happy to find a feature's requirements missing. But in the
end, you do not necessarily need to include these features in your
application. E.g., you could copy the
org.eclipse.platform-feature/feature.xml and use/require that copy
instead. In the future you could change the copy to include the
org.eclipse.platform feature when it's using the newer version of
org.apache.ant that you require, or use this as an opportunity to
Regards,
Ed
On 09.06.2020 02:30, Homer, Tony wrote:
Hi Jonah-
Thanks for the suggestions and
clarifications.
Yes, I did have the wrong link – I only
read the commit message and didn’t notice that the change was
only for the tests. After I realized that, I went ahead with
my own changes in which I replaced all the instances of ant
1.10.7 with the 1.10.8.qualifier that is in Orbit for
2020-06. So far I have not succeeded in completing a local
build, but I haven’t spent that much time on it, yet. I’m not
sure if I should be building with Java 8 or Java 11 – I tried
with both and had different problems with each.
>> If you are building your own app,
your app probably has its own .target or equivalent in the pom
file and in that file you can point at the new orbit
(2020-06), along with the older platform (4.15) version.
I did try this, pretty much exactly as you
suggest in my product’s target, but the exact version of ant
is hard-coded in the platform feature, so my build failed:
[ERROR] Missing
requirement: org.eclipse.platform.feature.group
4.15.0.v20200305-0155 requires 'org.eclipse.equinox.p2.iu;
org.apache.ant [1.10.7.v20190926-0324,1.10.7.v20190926-0324]'
but it could not be found
Before I go back to attempting a local
build, I’m going to try what I understand as Christoph
Läubrich’s suggestion to just swap out the version of Ant
after the build. I’m not sure if the version requirements get
checked at runtime, but it’s an easy thing to try.
Again, thank you for taking the time to
respond!
Tony Homer
Hi Tony,
I suspect that in your original message
you have the wrong link still - that may be the cause of
some of the confusion that seems to be in this
conversation. The commit you reference is a change only
to tests and I assume that you are not shipping tests nor
really need to rerun them as part of your RCP application.
The platform change that actually changes the version of
Ant that is shipped is
https://git.eclipse.org/r/163228
- along with some earlier updates that point at newer
orbit URLs that include the new ant version.
If you are building your own app, your
app probably has its own .target or equivalent in the pom
file and in that file you can point at the new orbit
(2020-06), along with the older platform (4.15) version.
You may need some version constraints in your .product
file to make sure that only the correct version of ant is
included.
On to some of your other questions in
case you have this or other reasons to rebuild the
platform:
> Still just wondering if it is
expected that such a change would be needed.
I think the change is needed as once a
version of Eclipse is released its branch is left in a
somewhat broken state because the I-build deps are
deleted. It may be nice if the branches for completed
versions were left in a buildable state, but that is not a
priority for active developers, so someone would have to
do that work. Please note that this problem exists
whenever you want to build an older version of Eclipse.
For example with the multi-repo builds of Eclipse it can
be quite hard to build an old version of Eclipse to, for
example, run git bisect to identify a problem. During
development lots of old I-builds are left so that you can
do that, but once a release is done those are removed.
I hope the above helps. Let me know if
I have misunderstood the direction you are aiming for.
Just wondering:
You wrote that you are having a RCP application, won't it
be easier to
simply patch the ant version in your final product?
Am 07.06.20 um 16:44 schrieb Homer, Tony:
> Hi Dani-
>
> Thanks for responding.
>
> Yes, updating to Ant 1.10.8 mitigates
> https://nvd.nist.gov/vuln/detail/CVE-2020-1945,
which is what I need to do.
>
> Tony Homer
>
> *From: *<platform-dev-bounces@xxxxxxxxxxx>
on behalf of Daniel Megert
> <daniel_megert@xxxxxxxxxx>
> *Reply-To: *"Eclipse platform general developers
list."
> <platform-dev@xxxxxxxxxxx>
> *Date: *Sunday, June 7, 2020 at 1:23 AM
> *To: *"Eclipse platform general developers list."
<platform-dev@xxxxxxxxxxx>
> *Subject: *Re: [platform-dev] backporting and
building?
>
> Hi Tony
>
> That commit only changes the Ant version in a test
class. Is this really
> what you want to backport?
>
> Dani
>
>
>
> From: "Homer, Tony" <tony.homer@xxxxxxxxx>
> To: "platform-dev@xxxxxxxxxxx"
<platform-dev@xxxxxxxxxxx>
> Date: 06.06.2020 22:51
> Subject: [EXTERNAL] [platform-dev] backporting and
building?
> Sent by: platform-dev-bounces@xxxxxxxxxxx
>
>
------------------------------------------------------------------------
>
> I have an RCP product that is currently building
against 4.15 and due to
> release timing I cannot update to 4.16 until after
the current release
> cycle.
>
> I’d like to backport this fix to 4.15:
>
>
https://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=4a27c8ad20b921af8df9731037aa756d70d6875f
>
> Applying the patch is no problem, but I’ve never
built platform before.
>
> I’m not sure if I need to check out all the repos or
can just checkout
> one of them.
>
> I’m not sure what build command to use.
>
> I looked for instructions, but there are none listed
on the developer
> resources page:
>
>
https://projects.eclipse.org/projects/eclipse.platform/developer
>
> I also looked at ci and it helped with the build
command, but I couldn’t
> work out what I need to do to setup my environment:
>
>
https://ci.eclipse.org/linuxtools/job/linuxtools-master/142/console
>
> Is there a doc that explains which repos to checkout
and what build
> command to use?
>
> Thanks!
>
> Tony
Homer_______________________________________________
> platform-dev mailing list
> platform-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit
>
https://www.eclipse.org/mailman/listinfo/platform-dev
>
>
>
>
> _______________________________________________
> platform-dev mailing list
> platform-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev
>
_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/platform-dev
_______________________________________________
platform-dev mailing list
platform-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev