Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mdt-ocl.dev] Compilation warnings 
Hi Axel
the only warnings that I get are in the EMF-generated code in *.testmodel.ngpm. Do you see others? Ununsed imports I have turned on as warnings, too. Outside of *testmodel.ngpm I don't see any. Do you?
Just 1 Dead Code, and 1 unused variable outside of 'test'. I'm using 3.7M5 JDT. For the most part each new JDT finds a few new warnings.
Are you suggesting to manually alter the EMF-generated code to get rid of the warnings?
Yes, provided the changes are trivial: Organise imports/add suppress warnings. Refactoring to enable JDT to understand null-ness may need an @generated NOT contribution.
Unchecked cast suppression seems to survive regeneration, so is well worth doing by hand.
Unused imports for x.y.x.* unfortunately keep getting inserted into Factory/Package/Switch so their removal is a tedious manual activity, but Ctrl-Shift-O isn't that hard.
But the goal is 0 warnings; any that are unsuppressed reflect inadequate attention by some project member. 

    Regards

        Ed


Best,
-- Axel

On 3/5/2011 8:01 AM, Ed Willink wrote:

Hi Axel

The Impact Analyzer is currently contributing about 50 warnings. Some
unused imports are very easy to fix. Other unchecked warnings, although
in EMF generated code, are also easy to suppress; EMF seems to preserve
the @suppress unchecked on regeneration.

In general, I aim to eliminate all warnings. Warnings that are present
are lazy Bugzillas awaiting attention; some, the longstanding 7 dead
code warnings in o.e.o do have a Bugzilla. The restricted warning from
o.e.o.uml also has a UML2 Bugzilla.

I'll try harder to improve my own warning contributions.

Regards

Ed
_______________________________________________
mdt-ocl.dev mailing list
mdt-ocl.dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mdt-ocl.dev



_______________________________________________
mdt-ocl.dev mailing list
mdt-ocl.dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/mdt-ocl.dev


-----
No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1204 / Virus Database: 1435/3481 - Release Date: 03/04/11

Back to the top