Re: [leshan-dev] Maven Eclipse Plugin

["Hudalla Kai (INST/ESY)" <Kai.Hudalla@xxxxxxxxxxxx>]

I see. Can we at least remove the following configuration from the maven eclipse plugin definition in the parent POM:

                    <configuration>
                            ...
                            <file>
                                <name>.settings/org.eclipse.core.runtime.prefs</name>
                                <location>${basedir}/../eclipse/settings/org.eclipse.core.runtime.prefs</location>
                            </file>
                            ...
                        </additionalConfig>
                    </configuration>


The problem with this is that it defines the default line ending to be \n (Unix style) and this makes it inconvenient to work on the code on Windows where people would usually have Git configured with core.autocrlf=true to have Git handle the conversion between CF and CRLF transparently.

Eclipse will adhere to the preferences setting and use LF as line delimiter on new files created as well as on files I edit. This then leads to some confusion when comparing with the previous revision since it then looks as if every line has changed.

I would therefore prefer to let Git handle the conversion between CRLF and LF and use default settings for line endings in eclipse, i.e. CRLF on Windows and LF on Linux (in which case no translation will occur anyways).

Would that work for you, Julien?

Kai


-------------
From: leshan-dev-bounces@xxxxxxxxxxx [mailto:leshan-dev-bounces@xxxxxxxxxxx] On Behalf Of Julien Vermillard
Sent: Thursday, October 22, 2015 9:28 AM
To: mike.milinkovich@xxxxxxxxxxx; leshan developer discussions
Subject: Re: [leshan-dev] Maven Eclipse Plugin

I have a 200 module project at work. M2E tends to be slower and buggy than mvn eclipse:eclipse (clean/refresh/update/pray/reboot-eclipse cycle for trying to solve random errors).
I'm using mars.1.

Julien

On Thu, Oct 22, 2015 at 5:03 AM Mike Milinkovich <mike.milinkovich@xxxxxxxxxxx> wrote:
On 21/10/2015 6:06 AM, Julien Vermillard wrote:
I disable m2e on my eclipse, it's just too buggy for me.
So -1 for me :)

Julien,

When was the last time you tried m2e? I would like to point you to the recent decision[1] by the Apache Maven project to retire their own plug-in because "Nowadays the Maven support for Eclipse is good and stable." (their words)

[1] http://mail-archives.apache.org/mod_mbox/maven-dev/201510.mbox/%3Cop.x55dxii1kdkhrr%40robertscholte.dynamic.ziggo.nl%3E




On Wed, Oct 21, 2015 at 11:25 AM Hudalla Kai (INST/ESY) <Kai.Hudalla@xxxxxxxxxxxx> wrote:
Hi,

I have been going through leshan's parent POM and noticed that we are still configuring the Maven Eclipse Plugin in there. This propably stems from a time when it was not that easy to import a maven project into eclipse and thus needed to create the eclipse project files using this plugin beforehand. However, times are a-changin' and my assumption is that most developers are using an eclipse version >= Luna today and thus can take advantage of the m2e eclipse plugin doing the job for them. I therefore think that we should simply remove the maven eclipse plugin definition from the POM which will also prevent the additional creation of the M2_REPO environment variable based additions to the build classpath which is simply not necessary anymore with modern eclipse versions.

Any objections?

Regards,
Kai

_______________________________________________
leshan-dev mailing list
leshan-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/leshan-dev