Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-dev] junits not hooked anywhere
  • From: "Sankaran, Srikanth" <srikanth.sankaran@xxxxxxxxxxxxx>
  • Date: Wed, 26 Jun 2024 11:40:07 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=advantest.com; dmarc=pass action=none header.from=advantest.com; dkim=pass header.d=advantest.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yv/UgyfwMT8wgXP2f1dtU77mPKOhzVZDN8Sv+FF7KqY=; b=kiizpKsiJHBseTyKr/8a9G8pymuX76gB1TVpBhf398LFv8oQcKs1MopbRRYAVrl60Y8avp0gTZXavMOLmr65hXDpr39KcCpLgKq/c66Kj9wrXnM/JB6h/iWnajYnxK6cvCsA43iLLwEX5leHayj6/lbwjACUFw4A5m0TtsvVNBal+O284XZXCMNs4OsmCsaa3Nn4jGcIGqer7C6tclxtr4jSvUaea02TFShL9t1t01elTnx8BZkxHhV17630ZNAb9d/WWzYKrVX+K/IZfTvqa+TzCBsoSe1TEt7TbScr9qMuA7GOXipNL1u7ZlNH53VIJMBc2Qlr5d1m802/DlKeAQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jK2aHogHyaK+ApKAu3UtUcKD3NTxFhl2iBlep8Hksm/VG94fAC+OlWnJuHhEH3KY3HHZWy4bU++EGxE1/+jZ8B4sCJQa5czg8gEWNHqOVuxb9hojqFrkMHqUtT+n393g4H7sd0jZIdhF5aABqb2qZVAwR82SGd8MajJu8sZoTnONal/qSu/3INOvd2foXb083M2AqoPpLgqg6gJ3T4pdCUaO+IFhJeQs75+e21DuvhyUcConZMQXV3CdOMhhd2gW2/h0nmajeFCrgNy9zoUgDa6CATO8uGFdu3Pp2PHoJLitRiFWcl4sy6I9EC3GtTeYI4Nc6oTvfLuCmiQTqaqb0w==
  • Delivered-to: jdt-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/jdt-dev/>
  • List-help: <mailto:jdt-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/jdt-dev>, <mailto:jdt-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/jdt-dev>, <mailto:jdt-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AdrBbdtqOW3vAcpiTXWh1XHiNqtDRgABtdQAAZIQkkA=
  • Thread-topic: [jdt-dev] junits not hooked anywhere
I found and fixed one more unhooked up junit: BatchCompilerTest_20.java (and hooked it up by moving the tests elsewhere) 

By "an automated way to locate such dangling files" I don't mean anything with as much rigor as to " if we can *detect* missing/dangling test automatically I don't see why not *execute* them automatically" - I was thinking of someone investing in a crude/quick & dirty way to enumerate junit files littered around for a human to eyeball and take suitable steps.

Srikanth

-----Original Message-----
From: jdt-dev <jdt-dev-bounces@xxxxxxxxxxx> On Behalf Of Christoph Läubrich via jdt-dev
Sent: Tuesday, June 18, 2024 5:13 PM
To: jdt-dev@xxxxxxxxxxx
Cc: Christoph Läubrich <laeubi@xxxxxxxxxxxxxx>
Subject: Re: [jdt-dev] junits not hooked anywhere

CAUTION: This email was sent from outside of Advantest.


The "usual way" is to actually look at the build results, if I add one one or more test but the testcount do not show a +1 (or larger) on the result page then something is missing ...

Beside that, if we can *detect* missing/dangling test automatically I don't see why not *execute* them automatically, so this is a chicken-egg problem, because we can't/want'/... use an automated detection (what e.g. usually works by define a name pattern) we have some preconfigured ones, but no automation can decide that something is missing from a set of "manually selected tests" to run...

Am 18.06.24 um 13:01 schrieb Sankaran, Srikanth via jdt-dev:
> I routinely run into instances where someone has created a junit test 
> file but has not hooked it anywhere:
>
> E.g: org.eclipse.jdt.core.tests.model.SealedTypeModelTests
>
> And till very recently (as of commit
> 148985eeafb27373226ac1a7ead4e7c5584f3d4b*)*
>
> **
>
> ReconcilerTest16
>
> This mail is to (a) alert committers of such dangling tests and (b) to 
> get folks to think about an automated way to locate such dangling files.
>
> We may be merging code that causes inadvertent regressions …
>
> Srikanth
>
>
> _______________________________________________
> jdt-dev mailing list
> jdt-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit 
> https://www.eclipse.org/mailman/listinfo/jdt-dev
_______________________________________________
jdt-dev mailing list
jdt-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jdt-dev

Back to the top