Right, didn't know that! Cool, so we can use this tool, AND count official votes. Great! :-) -Markus From: jaxrs-dev-bounces@xxxxxxxxxxx [mailto:jaxrs-dev-bounces@xxxxxxxxxxx] On Behalf Of Christian Kaltepoth
Sent: Dienstag, 27. Februar 2018 16:35
To: jaxrs developer discussions
Subject: Re: [jaxrs-dev] PR Review Voting: Comments to Github Tool? AFAIK everyone can perform a review via the "Review changes" button in the "Changed files" tab. Reviews by committers are displayed in green, while other reviews are displayed in gray. See for example this pull request. 2018-02-27 16:14 GMT+01:00 Santiago Pericas-Geertsen <santiago.pericasgeertsen@xxxxxxxxxx>:
On Feb 27, 2018, at 4:57 AM, Dennis Kieselhorst <mail@xxxxxxxxx> wrote: What I noticed in the meantime: It's not possible for everyone to use the Review Tooling, looks like this requires a special role. In this case the fallback to text comments is necessary. Is it possible to adjust the permissions? Unfortunately, I haven’t seen a way to tweak permissions of any kind. Anyone with more Eclipse experience can answer this? — Santiago
Am 27.02.2018 10:32, schrieb Alessio Soldano: Yes, definitely let's use B On Fri, Feb 23, 2018 at 9:16 PM, Dennis Kieselhorst <mail@xxxxxxxxx> wrote:
apparently we use different voting style for PRs, which makes it a bit hard for the assignee of a PR to count the actual votes. It would be good if we could agree on using one single voting style: (A) "+1", "0", "-1" text comments in the PR? (B) Using the Github Review Tool which exists for exactly this? (C) Something different?
Of course (B).
Regards
Dennis
_______________________________________________
jaxrs-dev mailing list
jaxrs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jaxrs-dev
_______________________________________________
jaxrs-dev mailing list
jaxrs-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jaxrs-dev
-- |
