Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jaxrs-dev] PR Review Voting: Comments to Github Tool?

What I noticed in the meantime: It's not possible for everyone to use the Review Tooling, looks like this requires a special role. In this case the fallback to text comments is necessary. Is it possible to adjust the permissions?

Am 27.02.2018 10:32, schrieb Alessio Soldano:

Yes, definitely let's use B

On Fri, Feb 23, 2018 at 9:16 PM, Dennis Kieselhorst <mail@xxxxxxxxx> wrote:
 

 

apparently we use different voting style for PRs, which makes it a bit hard for the assignee of a PR to count the actual votes. It would be good if we could agree on using one single voting style:

 

(A) "+1", "0", "-1" text comments in the PR?

 

(B) Using the Github Review Tool which exists for exactly this?

 

(C) Something different?

 

Of course (B).

Regards
Dennis
 

Back to the top