The EF's development process explains that only commiter have an "official" vote for PRs, hence Github is technically limited to only committers as reviewers. Certainly everybody's comments highly appreciated and will be considered, but for the assignee, it is simply mandatory to know how many committers actually vote +1 or -1. Hence, the review tool is the right choice.
-Markus
From: jaxrs-dev-bounces@xxxxxxxxxxx [mailto:jaxrs-dev-bounces@xxxxxxxxxxx] On Behalf Of Dennis Kieselhorst
Sent: Dienstag, 27. Februar 2018 10:58
To: jaxrs developer discussions
Subject: Re: [jaxrs-dev] PR Review Voting: Comments to Github Tool?
What I noticed in the meantime: It's not possible for everyone to use the Review Tooling, looks like this requires a special role. In this case the fallback to text comments is necessary. Is it possible to adjust the permissions?
Am 27.02.2018 10:32, schrieb Alessio Soldano:
Yes, definitely let's use B
On Fri, Feb 23, 2018 at 9:16 PM, Dennis Kieselhorst <mail@xxxxxxxxx> wrote:
apparently we use different voting style for PRs, which makes it a bit hard for the assignee of a PR to count the actual votes. It would be good if we could agree on using one single voting style:
(A) "+1", "0", "-1" text comments in the PR?
(B) Using the Github Review Tool which exists for exactly this?
(C) Something different?
Of course (B).
Regards
Dennis
