Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] Draft pull request for adding Maven pom to each Platform TCK test folder...
I'm +1 on the convention `stc/test`,
By looking at the cdi-tck it looks it follow this convention in modules like this https://github.com/eclipse-ee4j/cdi-tck/tree/master/impl/src/test
But you are right, there are another tests related folders like: https://github.com/eclipse-ee4j/cdi-tck/tree/master/web/src/main/java/org/jboss/cdi/tck/interceptors/tests but I don't have the context of this ones.


On Mon, Aug 30, 2021 at 9:32 AM Scott Marlow <smarlow@xxxxxxxxxx> wrote:
On 8/24/21 2:49 PM, Scott Marlow wrote:

To (start) addressing issue 51 [1], [2] adds a minimal maven `pom.xml` to each test folder using the existing test directories.  There are missing dependencies currently (so expect build failures), some that need to be discussed as to how to address (e.g. com.sun.javatest).

We are building still with Java SE 8 and will switch to Java SE 11 soon enough. 

If anyone wants to improve the initial pom.xml files, your help is greatly appreciated! 

As a next step, I'm thinking we should convert each test module to follow the Maven `src/test` or `src/main` convention.  I'm not sure of any strong reasons to prefer one other the other but if anyone does, please speak up.  From a quick look, I see github.com/eclipse-ee4j/cdi-tck + github.com/eclipse-ee4j/batch-tck using `src/main` for test sources and github.com/eclipse-ee4j/beanvalidation-tck using `src/test` for test sources.

Scott

If anyone wants to help eliminate the Java Test harness (com.sun.javatest [4]) missing dependencies in [2], your help is greatly appreciated!  This is an area that we need to explore to understand more.  Whomever looks at this part, needs to come up with different paths that we can choose from. 

We can discuss more on the September 8th (or 9th depending on your time zone) TCK zoom call [5].  Note that [5] is the TCK call agenda document and contains a link to the (Jakarta EE Specifications) calendar.

The initial refactoring goal is to have a place to explore updating each test folder to be able to run TCK tests against the different EE container test vehicles with JUnit5/TestNG + Arquillian. 

We also will integrate with any EE container tests produced by any of the Spec API teams (e.g. see [6][7] for possible examples).

Scott

[1] https://github.com/eclipse-ee4j/jakartaee-tck/issues/51
[2] https://github.com/eclipse-ee4j/jakartaee-tck/pull/735
[3] https://github.com/eclipse-ee4j/jakartaee-tck/tree/tckrefactor
[4] https://github.com/openjdk/jtharness
[5] https://docs.google.com/document/d/1V1dDLJkd14EDRMPeuI0VzPtU4Lbli8FFBd1pLDLlOrY/edit#
[6] https://github.com/eclipse-ee4j/batch-tck/
[7] https://github.com/eclipse-ee4j/jaxrs-api/pull/1002

_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

Back to the top