[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [jakartaee-tck-dev] TCK compile failure due to javax.ejb => jakarta.ejb change for TCK master branch...
|
web-jsptaglibrary_2_1.xsds is in the Java EE 5 schema repo. I guess
I'll need to file another CQ to contribute it. Can someone please
do an audit and ensure that no others were missed?
I created
CQ
21868.
Wait for it to be approved, then add the file and update it as
needed.
Kevin Sutter wrote on 3/26/20 7:39 AM:
Scott,
Since you
brought
up the XSDs... We're having problems with finding the proper
home
for the web-jsptaglibrary_2_1.xsd... As you can see in this
spreadsheet,
the only location we have found this particular XSD is in the
TCK repo...
I'm assuming the source for this XSD should be in another repo
--
jakartaee-schemas, most likely.
https://docs.google.com/spreadsheets/d/1cCGLYsCVz9pkUnMCdwaiLraepcxuemMbmUymgdMKUQY/edit#gid=0
I created an
Issue
for this: https://github.com/eclipse-ee4j/jakartaee-tck/issues/172
If anybody on
this list can help get this resolved, I'd appreciate the
assistance. Thanks!
---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail: sutter@xxxxxxxxxx Twitter: @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter
From:
Scott
Marlow <smarlow@xxxxxxxxxx>
To:
Alwin
Joseph <alwin.joseph@xxxxxxxxxx>
Cc:
jakartaee-tck
developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>
Date:
03/26/2020
08:54
Subject:
[EXTERNAL]
Re: [jakartaee-tck-dev] TCK compile failure due to javax.ejb
=> jakarta.ejb
change for TCK master branch...
Sent
by: jakartaee-tck-dev-bounces@xxxxxxxxxxx
Also just noticed that I changed
lib/schemas/web-facesconfig*.xsd
+ lib/schemas/web-jsptaglibrary_2_1.xsd with my global search +
replace,
I will revert these changes, as we can expect new xml schemas
will be created
for Jakarta EE 9, instead of updating these existing ones.
Scott
On Thu, Mar 26, 2020 at 9:37 AM
Scott
Marlow <smarlow@xxxxxxxxxx>
wrote:
Thanks for the response Alwin, I
appreciate
hearing from you.
I just started preparing a change
for
javax.el => jakarta.el and am reminded of the docker/fix_classpaths.sh
script, which I think our CI is using (via "Jenkinsfile" in
root
of tck repo), to update the ts.jte properties. So that could
be a
possible way to temporarily alter the classpath values in
ts.jte for building +
running the TCK on Jenkins CI.
I was also reminded (from git diff
output)
of the docker/scripts/tcks/eltck.sh file which I think needs to
sync up
with EL TCK settings, my quick global and replace, made the
following change,
which might not be needed yet or perhaps that should be done
separately
(later):
-sed -i
"s#^el\.classes=.*#el.classes=$TS_HOME/lib/javatest.jar:$TCK_HOME/glassfish5/glassfish/modules/javax.el.jar#g"ts.jte
+sed -i
"s#^el\.classes=.*#el.classes=$TS_HOME/lib/javatest.jar:$TCK_HOME/glassfish5/glassfish/modules/jakarta.el.jar#g"ts.jte
To do the global search + replace, I'm using:
ag --ignore .git -l javax.el|
xargs sed -i 's/javax\.el\./jakarta\.el\./g'
I'll revert
the docker/scripts/tcks/eltck.sh
change for now.
Scott
On Thu, Mar 26, 2020 at 2:08 AM
Alwin
Joseph <alwin.joseph@xxxxxxxxxx>
wrote:
Hi Scott,
Thanks for noticing the failure.
This
was supposed to be a temporary change but it was not enough to
get the
build passing. As you observed the classpath values in ts.jte
will also
need a change to include the jar.
Regards,
Alwin
On 25/03/20 10:34 PM, Scott Marlow
wrote:
Hi,
The https://github.com/eclipse-ee4j/jakartaee-tck/commit/e8e07d2103b45c6d189fe7f811fc22dfa8fcf848 added
the following to build_jakartaeetck.sh:
"
wget --progress=bar:force --no-cache
https://repo1.maven.org/maven2/jakarta/platform/jakarta.jakartaee-api/9.0.0-RC1/jakarta.jakartaee-api-9.0.0-RC1.jar
mv
jakarta.jakartaee-api-9.0.0-RC1.jar
$GF_HOME/glassfish5/glassfish/modules
"
I can see that
jakarta.jakartaee-api-9.0.0-RC1.jar
contains jakarta.ejb.* classes, but I suspect that we need to do
more for
switching to build the TCK with use of jakarta.ejb in TCK
sources, as the
nightly build compile step fails to import jakarta.ejb classes:
"
compile:
[ts.javac] Compiling 65 source files to
/home/jenkins/agent/workspace/jakartaee-tck_master/classes
[ts.javac] Picked up JAVA_TOOL_OPTIONS: -Xmx6G
[ts.javac]
/home/jenkins/agent/workspace/jakartaee-tck_master/src/com/sun/ts/tests/interop/csiv2/common/CSIv2AppClient.java:25:error:
package jakarta.ejb does not exist
[ts.javac] import jakarta.ejb.*;
"
Should we replace
{ri.modules}/jakarta.ejb-api.jar
in the ts.jte with jakarta.jakartaee-api-9.0.0-RC1.jar (either
in
the Jenkins job or via change to ts.jte)?
Will the GlassFish
jakarta.jakartaee-api
always contain all of the spec api classes? If yes, then it may
work
to update ts.jte to use that (once all of the javax references
are changed
to jakarta namespace).
Scott
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev__;!!GqivPVa7Brio!I42DESlFCunDwAFc6RrsFDqIXCfiPerkUxHqXAtFwNviRMyeL_cMdvDpeQFa5uVkDg$
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev__;!!GqivPVa7Brio!OFKhGgpvAvtIiEN3qyq9WPbrRYznWmxhFQC9P2vuXflMS0tzhzAfIuDJNNsEWHSeqg$