So many issues here...
The EE4J_8 branch should've been merged into master by now.
Jakarta EE 8 is supposed to be the same as Java EE 8. Neither the
Java EE 8 API docs nor the Java EE 8 Servlet specification document
have any indication of deprecating the ServletContext.getRealPath
method. If that was "supposed" to have been done for Java EE 8, it
wasn't, and now we have to live with that.
Adding the @Deprecated annotation in 4.0.3 would fail the signature
test and thus would not be compatible with the Servlet 4.0 spec.
This change would need to wait until Servlet 4.1.
If 4.0.2 has all the changes for Jakarta EE 8, it's fine to do
advance work for a future 4.0.3, but that work probably shouldn't be
done on master, and obviously that work would need to be compatible
with Servlet 4.0. And of course testing for Jakarta EE 8 should be
done against the version that has all the changes needed for Jakarta
EE 8.
Tom Jenkinson wrote on 8/20/19 10:12
AM:
I just heard that
https://github.com/eclipse-ee4j/servlet-api/blob/EE4J_8/api/src/main/java/javax/servlet/ServletRequest.java
doesn't include the @Deprecated change, so this could be
an user error
(should be using EE4J_8 branch).
Sorry for the noise. :)
Scott
On 8/20/19 12:18 PM, Joakim Erdfelt wrote:
> If the Jakarta EE 8 release is supposed to be
bytecode compatible with
> Java EE 7, then yeah, I agree the @Deprecated
shouldn't be there for the
> Jakarta EE 8 release.
>
> Linking to ApiDocs for Java EE 7 for
ServletContext.getRealPath(String) ...
> https://docs.oracle.com/javaee/7/api/javax/servlet/ServletContext.html#getRealPath-java.lang.String-
>
> Besides, I don't think we are allowed to change the
TCK behavior for
> Jakarta EE 8.
> Is this a correct assumption?
>
>
> On Tue, Aug 20, 2019 at 10:34 AM Scott Marlow <smarlow@xxxxxxxxxx
> <mailto:smarlow@xxxxxxxxxx>>
wrote:
>
> Hi,
>
> Servlet 2.1 deprecated
ServletRequest#getRealPath(String path) however,
> the current Jakarta platform TCK signature test
doesn't allow
> @Deprecated annotation to be added to
ServletRequest#getRealPath
> [1], so
> we are seeing Jakarta TCK signature failure [2].
>
> Should the @Deprecated annotation be removed from
[1] to resolve the
> tck
> [2] failure?
>
> Scott
>
> [1]
> https://github.com/eclipse-ee4j/servlet-api/blob/master/api/src/main/java/javax/servlet/ServletRequest.java#L362
>
> [2] Added Annotations
> [javatest.batch] -----------------
> [javatest.batch]
> [javatest.batch] javax.servlet.ServletRequest:
> getRealPath(java.lang.String):anno 0
java.lang.Deprecated()
> [javatest.batch]
> [javatest.batch]
> [javatest.batch]
> [javatest.batch] 08-19-2019 22:31:36: SVR:
********** Package
> 'javax.servlet' - FAILED (STATIC MODE) **********
> _______________________________________________
> jakartaee-tck-dev mailing list
> jakartaee-tck-dev@xxxxxxxxxxx
<mailto:jakartaee-tck-dev@xxxxxxxxxxx>
> To change your delivery options, retrieve your
password, or
> unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
>
>
> _______________________________________________
> jakartaee-tck-dev mailing list
> jakartaee-tck-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your
password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
>
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password,
or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev
|
