Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakartaee-tck-dev] com/sun/ts/tests/signaturetest/javaee/JavaEESigTest.java#signatureTest_from_servlet failure due to Deprecated annotation added to ServletRequest.java...
I created https://github.com/eclipse-ee4j/servlet-api/pull/264 in case that is helpful. 

On 8/20/19 1:25 PM, Kevin Sutter wrote:
Hmmm..  According to the Servlet 4.0 Spec PR, they are trying to promote 4.0.3: 
https://github.com/jakartaee/specifications/pull/61/files

So, only testing against 4.0.2 is not sufficient.

---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect
e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter



From: Tom Jenkinson <tom.jenkinson@xxxxxxxxxx>
To: jakartaee-tck developer discussions <jakartaee-tck-dev@xxxxxxxxxxx>
Date: 08/20/2019 12:12 PM
Subject: [EXTERNAL] Re: [jakartaee-tck-dev] com/sun/ts/tests/signaturetest/javaee/JavaEESigTest.java#signatureTest_from_servlet failure due to Deprecated annotation added to ServletRequest.java... 
Sent by: jakartaee-tck-dev-bounces@xxxxxxxxxxx
------------------------------------------------------------------------
OTOH 4.0.2 does not _https://github.com/eclipse-ee4j/servlet-api/blob/4.0.2-RELEASE/src/main/java/javax/servlet/ServletRequest.java#L431_and 4.0.2 is what the servlet team (seem to be) certifying with: _https://github.com/eclipse-ee4j/servlet-api/issues/262_
On Tue, 20 Aug 2019 at 18:06, Tom Jenkinson <_tom.jenkinson@redhat.com_ <mailto:tom.jenkinson@xxxxxxxxxx>> wrote: The 4.0.3 tag does have that @Deprecated: _https://github.com/eclipse-ee4j/servlet-api/blob/4.0.3-RELEASE/api/src/main/java/javax/servlet/ServletRequest.java#L363_
On Tue, 20 Aug 2019 at 17:59, Scott Marlow <_smarlow@redhat.com_ <mailto:smarlow@xxxxxxxxxx>> wrote: 

I just heard that _
__https://github.com/eclipse-ee4j/servlet-api/blob/EE4J_8/api/src/main/java/javax/servlet/ServletRequest.java_
doesn't include the @Deprecated change, so this could be an user error
(should be using EE4J_8 branch).

Sorry for the noise. :)

Scott

On 8/20/19 12:18 PM, Joakim Erdfelt wrote:

If the Jakarta EE 8 release is supposed to be bytecode compatible  with
Java EE 7, then yeah, I agree the @Deprecated shouldn't be there  for the
Jakarta EE 8 release.

Linking to ApiDocs for Java EE 7 for ServletContext.getRealPath(String)  ...
_https://docs.oracle.com/javaee/7/api/javax/servlet/ServletContext.html#getRealPath-java.lang.String-_

Besides, I don't think we are allowed to change the TCK behavior for
Jakarta EE 8.
Is this a correct assumption?


On Tue, Aug 20, 2019 at 10:34 AM Scott Marlow <_smarlow@redhat.com_ <mailto:smarlow@xxxxxxxxxx>
<mailto:_smarlow@redhat.com_ <mailto:smarlow@xxxxxxxxxx>>> wrote:

     Hi,

     Servlet 2.1 deprecated ServletRequest#getRealPath(String  path) however,
     the current Jakarta platform TCK signature test  doesn't allow
     @Deprecated annotation to be added to ServletRequest#getRealPath
     [1], so
     we are seeing Jakarta TCK signature failure [2].

     Should the @Deprecated annotation be removed from  [1] to resolve the
     tck
     [2] failure?

     Scott

     [1]
    _https://github.com/eclipse-ee4j/servlet-api/blob/master/api/src/main/java/javax/servlet/ServletRequest.java#L362_

     [2] Added Annotations
     [javatest.batch] -----------------
     [javatest.batch]
     [javatest.batch] javax.servlet.ServletRequest:
     getRealPath(java.lang.String):anno 0 java.lang.Deprecated()
     [javatest.batch]
     [javatest.batch]
     [javatest.batch]
     [javatest.batch] 08-19-2019 22:31:36:  SVR:  ********** Package
     'javax.servlet' - FAILED (STATIC MODE) **********
     _______________________________________________
     jakartaee-tck-dev mailing list
_jakartaee-tck-dev@eclipse.org_
<mailto:jakartaee-tck-dev@xxxxxxxxxxx><mailto:_jakartaee-tck-dev@eclipse.org_ <mailto:jakartaee-tck-dev@xxxxxxxxxxx>> 
     To change your delivery options, retrieve your  password, or
     unsubscribe from this list, visit
    _https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev_


_______________________________________________
jakartaee-tck-dev mailing list
_jakartaee-tck-dev@eclipse.org_ <mailto:jakartaee-tck-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or unsubscribe  from this list, visit
_https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev_


_______________________________________________
jakartaee-tck-dev mailing list_
__jakartaee-tck-dev@eclipse.org_ <mailto:jakartaee-tck-dev@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or unsubscribe from this list, visit_ 
__https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev________________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev



_______________________________________________
jakartaee-tck-dev mailing list
jakartaee-tck-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakartaee-tck-dev

Back to the top