Re: [jakartaee-spec-project-leads] How do I get "Require pull request re

[Mark Thomas <markt@xxxxxxxxxx>]

On 28/02/2020 15:21, Kevin Sutter wrote:
> Is removing the "required review" the proper path?

In my view, in this instance, yes.

JSP has a small number of active participants. To me, this rule is the
biggest barrier to participation at the moment. It is unusual for there
to be more than one of the participants focussed on the project at
anyone time. When you are focused on the project it doesn't take long
before you reach the point where you want to (or need to) commit to
master before continuing. You then get blocked waiting for the PR to be
approved. This kills momentum and significantly slows progress.

I am a big fan of social controls over technical controls.

I am going to go ahead and propose this change on the JSP dev list.

>  It seems that we
> have a bigger issue with JSP (and possibly other components) if we are
> not getting the proper and needed participation.  If the current
> committers on JSP are not helping out, then maybe we need some fresh
> participants?

We always need more participants.

> Are there others that should be nominated for
> committership?

There are one or two prospects. I'll take a look at their contributions
and see if a nomination is justified. It probably is. We need to keep
the bar pretty low.

> Or, do we need to "wake up" some of the current participants?

We can't force folks to spend time on this project.

> Mark, I'm hitting a similar issue with the JSTL project with no reviews
> happening on one of my PRs.  But, I'm not even a committer, so even
> removing that review requirement won't help me.

Yuck. Sorry I can't help there. I'm not a JSTL committer either.

> My thought is that we should try to address the problem of inactivity
> rather than lifting the required review.

I disagree. Activity breeds participation. The required review is having
a negative impact on activity.

> Otherwise, we could end up
> with individuals taking a project down a path that is not good for the
> long-term prospects of the project.

If a project reaches a point where there is only a single individual
working on it the direction that individual takes it is far from the
biggest risk to the long term health of the project.

> Not implying this about your
> participation, Mark.  I'm just using this as an example.

Actually, I think the direction risk is easily mitigated. One,
everything is in version control so we can revert / start again from the
tag of the last release / do something else easily. Two the requirement
to have a functional RI provides an additional sanity check.

Mark


> 
> ---------------------------------------------------
> Kevin Sutter
> STSM, MicroProfile and Jakarta EE architect @ IBM
> e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
> phone: tl-553-3620 (office), 507-253-3620 (office)    
> LinkedIn: https://www.linkedin.com/in/kevinwsutter
> 
> 
> 
> From:        Ivar Grimstad <ivar.grimstad@xxxxxxxxxxxxxxxxxxxxxx>
> To:        JakartaEE Spec Project Leadership discussions
> <jakartaee-spec-project-leads@xxxxxxxxxxx>
> Date:        02/28/2020 07:25
> Subject:        [EXTERNAL] Re: [jakartaee-spec-project-leads] How do I
> get "Require pull request reviews before merging" removed?
> Sent by:        jakartaee-spec-project-leads-bounces@xxxxxxxxxxx
> ------------------------------------------------------------------------
> 
> 
> 
> Hi Mark,
> 
> No need for a formal vote. And email on the project mailing list should
> be sufficient. 
> First of all, encourage committers to review the PR.
> Then suggest the change to lift the review requirement. If nobody
> opposes, approve by lazy consensus and file the Bugzilla for it.
> 
> Ivar
> 
> On Fri, Feb 28, 2020 at 6:22 AM arjan tijms <_arjan.tijms@gmail.com_
> <mailto:arjan.tijms@xxxxxxxxx>> wrote:
> Hi,
> 
> I'm in favour of removing that requirement for JSP and at least for
> Mark. There's a setting for that on GitHub that admins can simply switch
> off. Not sure if it can be done per person or per group.
> 
> We have version control so anything controversial can be rolled back.
> I'm not expecting Mark to just do anything controversial out of the
> blue. Indeed, IMHO reviews for the kind of work we're currently doing on
> projects that are not that active are mostly counter productive.
> 
> Kind regards,
> Arjan
> 
> 
> 
> 
> On Fri, Feb 28, 2020 at 12:16 PM Jonathan Gallimore
> <_jgallimore@tomitribe.com_ <mailto:jgallimore@xxxxxxxxxxxxx>> wrote:
> Hi Mark,
> 
> I'm assuming this is the PR you're referring
> to: _https://github.com/eclipse-ee4j/jsp-api/pull/139_
> 
>> Currently at 19 days and counting.
> 
> That does sound like a long time. Do we need more committers on the
> project? Is there a way that we can give people review access, but
> perhaps not commit?
> 
> I'm not a committer on the JSP API project, so a review from me wouldn't
> count towards actually getting it merged, but I'd be very happy and
> willing to review your PR and provide feedback. I can't do it
> immediately, would be able to look at it this afternoon/evening, so you
> could expect something by Monday morning.
> 
> Thanks for flagging this up - it certainly sounds like we need to
> address it quickly - one way or another.
> 
> Jon
> 
> 
> On Fri, Feb 28, 2020 at 10:59 AM Mark Thomas <_markt@apache.org_
> <mailto:markt@xxxxxxxxxx>> wrote:
> 
> Hi,
> 
> My work on the JSP project is stalled - yet again - waiting for a PR to
> be approved. This time it is for the first pass at tidying up the spec
> doc. Currently at 19 days and counting.
> 
> I would like to get the "Require pull request reviews before merging"
> setting removed from the project. How do I go about doing that? Is it a
> request via Bugzilla? Do I need to hold a project vote first (not sure
> who is actually going to vote if I did)? Something else?
> 
> Thanks,
> 
> Mark
> _______________________________________________
> jakartaee-spec-project-leads mailing list_
> __jakartaee-spec-project-leads@eclipse.org_
> <mailto:jakartaee-spec-project-leads@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit_
> __https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads_
> 
> 
> -- 
> 
> 
> Jonathan Gallimore
> _http://www.tomitribe.com_ <http://www.tomitribe.com/>
> 
> _______________________________________________
> jakartaee-spec-project-leads mailing list_
> __jakartaee-spec-project-leads@eclipse.org_
> <mailto:jakartaee-spec-project-leads@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit_
> __https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads_
> 
> _______________________________________________
> jakartaee-spec-project-leads mailing list_
> __jakartaee-spec-project-leads@eclipse.org_
> <mailto:jakartaee-spec-project-leads@xxxxxxxxxxx>
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit_
> __https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads_
> 
> 
> 
> 
> -- 
> 
> Ivar Grimstad
> 
> Jakarta EE Developer Advocate | Eclipse Foundation, Inc.
> 
> 
> /_Eclipse Foundation_/ <http://www.eclipse.org/>/: The Platform for Open
> Innovation and Collaboration/_______________________________________________
> jakartaee-spec-project-leads mailing list
> jakartaee-spec-project-leads@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads
> 
> 
> 
> 
> _______________________________________________
> jakartaee-spec-project-leads mailing list
> jakartaee-spec-project-leads@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads
>