Re: [jakartaee-spec-project-leads] How do I get "Require pull request re

[Jonathan Gallimore <jgallimore@xxxxxxxxxxxxx>]

Hi Mark,

I'm assuming this is the PR you're referring to: https://github.com/eclipse-ee4j/jsp-api/pull/139

> Currently at 19 days and counting.

That does sound like a long time. Do we need more committers on the project? Is there a way that we can give people review access, but perhaps not commit?

I'm not a committer on the JSP API project, so a review from me wouldn't count towards actually getting it merged, but I'd be very happy and willing to review your PR and provide feedback. I can't do it immediately, would be able to look at it this afternoon/evening, so you could expect something by Monday morning.

Thanks for flagging this up - it certainly sounds like we need to address it quickly - one way or another.

Jon

On Fri, Feb 28, 2020 at 10:59 AM Mark Thomas <markt@xxxxxxxxxx> wrote:

Hi,

My work on the JSP project is stalled - yet again - waiting for a PR to
be approved. This time it is for the first pass at tidying up the spec
doc. Currently at 19 days and counting.

I would like to get the "Require pull request reviews before merging"
setting removed from the project. How do I go about doing that? Is it a
request via Bugzilla? Do I need to hold a project vote first (not sure
who is actually going to vote if I did)? Something else?

Thanks,

Mark
_______________________________________________
jakartaee-spec-project-leads mailing list
jakartaee-spec-project-leads@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads

--

Jonathan Gallimore

http://www.tomitribe.com