Hi Kai,
I realize that the repo didn’t have a CONTRIBUTING.md guide like the asset tracking testbed does. See [1], now. Hopefully this should answer your questions regarding how pull requests are accepted, and who can be(come) a committer on the testbed repos.
Benjamin -
On 15.12.2017 16:28, Benjamin Cabé wrote:Hi Kai,
In general I think that having the code on a private GH repo will just make things very complex to deal with. If you already have the liberty to add external collaborators to the bsinno repo, this is already not very different to collaborating on an eclipselabs GH repo? Unless the collaborators would be read-only? I would happy to work with you on what could be a solution that would work for Bosch, keeping in mind that the testbeds are, in my sense, meant to have a slightly looser IP policy than a typical Eclipse project, since it might be in the partners’ interests to work on glue code that depends on commercial solutions, for example. Who is supposed to have write access to the testbed repo mentioned above, are you the only "committer"? How does a contribution work? I assume I need to create a PR and you will then review and (hopefully) accept it?
Did you have a chance to work on the architecture/component diagram in the meantime? Not yet, sorry, Hono is eating up all my time preparing the upcoming 0.5 release ...
Thanks! Benjamin -
PS: if you could add me (kartben) to the repo, that would be great.
Hi, I have set up a (private) GitHub repository [1] for collaborating on the back end component(s)/glue code of the I4.0 test bed. Bosch currently is not in a position to contribute code to a public GitHub repository that is not governed by a thorough intellectual property process as e.g. the Eclipse Foundation implements. However, I can add anybody as a collaborator to our private GitHub repository so that we can work together on the I4.0 test bed code that is not already part of the upstream projects, i.e. Unide, Hono [2], Camel etc. I have added the initial version of the back end component for processing PPMP messages received via Hono to the repository. The component is implemented as a Camel route using Camel's AMQP 1.0 endpoint for consuming messages from Hono. Devices can then publish PPMP messages via HTTP or MQTT using Hono's protocol adapters.
So, if you want to work on the code, drop me a line so that I can add you as a collaborator. BTW I will also create a high level component diagram illustrating the overall architecture envisioned for the I4.0 testbed.
[1] https://github.com/bsinno/eclipse-i40-testbed [2] https://www.eclipse.org/hono -- Mit freundlichen Grüßen / Best regards
Kai Hudalla Chief Software Architect
Bosch Software Innovations GmbH Ullsteinstraße 128 12109 Berlin GERMANY www.bosch-si.com
Registered Office: Berlin, Registration Court: Amtsgericht Charlottenburg; HRB 148411 B Chairman of the Supervisory Board: Dr.-Ing. Thorsten Lücke; Managing Directors: Dr.-Ing. Rainer Kallenbach, Michael Hahn _______________________________________________ iot-testbeds mailing list iot-testbeds@xxxxxxxxxxxTo change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/iot-testbeds
_______________________________________________
iot-testbeds mailing list
iot-testbeds@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-testbeds
-- Mit freundlichen Grüßen / Best regards
Kai Hudalla Chief Software Architect
Bosch Software Innovations GmbH Ullsteinstraße 128 12109 Berlin GERMANY www.bosch-si.com
Registered Office: Berlin, Registration Court: Amtsgericht Charlottenburg; HRB 148411 B Chairman of the Supervisory Board: Dr.-Ing. Thorsten Lücke; Managing Directors: Dr.-Ing. Rainer Kallenbach, Michael Hahn _______________________________________________iot-testbeds mailing listiot-testbeds@xxxxxxxxxxxTo change your delivery options, retrieve your password, or unsubscribe from this list, visithttps://dev.eclipse.org/mailman/listinfo/iot-testbeds
|