Re: [ice-dev] [ice-build] [eclipse/ice] 80c70c: Fixing bugs encountered

["McCaskey, Alex" <mccaskeyaj@xxxxxxxx>]

Hey Everyone, 

I just wanted to take a second and point out this commit I made yesterday, and how it points out how important it is that we all try out each other’s code. 

Jay had written some complicated code in the projectSupport branch that enabled the underlying Eclipse platform to pick out whether an XML file in a project was just that, or whether it was an ICE XML file. This isn’t easy and required creating extensions for the common navigator framework. 

I pulled this down and was cleaning it up for a merge into next and found that if I had created a MOOSE Item in the default project (that’s right, this branch will soon enable Items in individual projects) then when I opened the project and triggered the platform to figure out whether this was an ICE XML file or not, I couldn’t do something simple like refresh the project. All of ICE would freeze saying it was waiting on some background task. I searched forever for what this might be and found that the extension used to parse whether this was an ICE XML file had a very simple bug - a while loop that never terminated because a counter wasn’t being incremented. I added the simple counter++ and everything worked normally. 

I just wanted to use this opportunity to point out how important it is for us to always pull down each other’s code and try it out. It’s not enough for one person to write a piece of code, ensure the tests pass, then everyone just say it’s 100% right. We have to check it out, run our Items and make sure everything still works, especially since we all develop on different operating systems. This is another reason why we are beefing up our SWTBot tests.  

Anyway, stepping down off the soapbox now. Thanks for your time.

Alex


> On Oct 13, 2015, at 12:19 PM, GitHub <noreply@xxxxxxxxxx> wrote:
> 
>  Branch: refs/heads/jay/projectSupport
>  Home:   https://github.com/eclipse/ice
>  Commit: 80c70c7df16d70b9cd5f4911c6d61f310fd62d7a
>      https://github.com/eclipse/ice/commit/80c70c7df16d70b9cd5f4911c6d61f310fd62d7a
>  Author: amccaskey <mccaskeyaj@xxxxxxxx>
>  Date:   2015-10-13 (Tue, 13 Oct 2015)
> 
>  Changed paths:
>    M org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEFormEditor.java
>    M org.eclipse.ice.io/.settings/org.eclipse.jdt.core.prefs
>    M org.eclipse.ice.io/META-INF/MANIFEST.MF
>    M org.eclipse.ice.io/src/org/eclipse/ice/io/serializable/IOService.java
>    M org.eclipse.ice.io/src/org/eclipse/ice/io/serializable/IReader.java
>    M org.eclipse.ice.io/src/org/eclipse/ice/io/serializable/IWriter.java
>    M org.eclipse.ice.item/src/org/eclipse/ice/item/Item.java
>    M org.eclipse.ice.item/src/org/eclipse/ice/item/nuclear/MOOSEModel.java
>    M org.eclipse.ice.persistence.xml/src/org/eclipse/ice/persistence/xml/XMLFormContentDescriber.java
>    M org.eclipse.ice.repository/ice.macosx_product.launch
> 
>  Log Message:
>  -----------
>  Fixing bugs encountered when using MOOSE Item
> 
> First bug - IReader used by MOOSEModel was null due to the fact that we
> are switching to extension points for our IReader/IWriter interface
> realizations. Set up the IOService to add all available
> IReaders/IWriters from extension points to itself
> 
> Second bug - Found that when an Item XML file was in the project, and I
> went to refresh or close the workspace it would hang and throw up a
> dialog that said waiting on background task forever. Turns out the
> XMLFormContentDescriber was stuck in an infinite loop reading the XML
> contents to tell if it was a ICE Item or not. Fixed that and everything
> works as expected. 
> 
> Signed-off-by: amccaskey <mccaskeyaj@xxxxxxxx>
> 
> 
> _______________________________________________
> ice-build mailing list
> ice-build@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ice-build