Re: [eclipse-dev] Moving the Bug reference to the meta data in the Git c

[Leo Ufimtsev <Leonidas@xxxxxxxxxx>]

I think Lars has a point about having a more meaningful summary in the first line. I would suggest to keep the 'Bug XXXXX' format, but be flexible with the description.

Bug 12345 <your description>

Further, I sometimes add an alias to the bug and write the title like so:

Bug 12345 (ALIAS) <your description>

This is particularly useful when you submit multiple patches per bug.  e.g

Bug 12345 (ALIAS) part 1 of great fix

Bug 12345 (ALIAS) part 2 of great fix, improving on great fix,

Bug 12345 (ALIAS) part 3 of great fix, fixing that regression the great fix caused,

This helps keeping the bug id, have an easy way to identify related bug via alias and have a meaningful summary.

On Thu, May 31, 2018 at 10:09 AM, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:

> You think it's not an improvement, but do you think it's worse?

Yes, definitely. What does # in [#] mean? Change ID? Bugzilla ID? Git issue ID? ... Just to save 2 characters? Really?

Dani



From:        Mickael Istria <mistria@xxxxxxxxxx>
To:        "General development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>
Date:        31.05.2018 16:05
Subject:        Re: [eclipse-dev] Moving the Bug reference to the meta data in the Git commit footer?
Sent by:        eclipse-dev-bounces@eclipse.org

---

On Thu, May 31, 2018 at 2:34 PM, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
I disagree that this is an improvement

What are your criteria about acceptable commit messages?
You think it's not an improvement, but do you think it's worse?

That said, Lars comment about autolinking from Gerrit is important, and before adopting this, we need to make sure that linking works or at least is going to work.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=421151already covers that.
 
and it only saves 2 and not 4 characters.

I think you forgot to count the whitespaces._______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev



_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev

--

Leo Ufimtsev, Software Engineer, Red Hat