Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [eclipse-dev] Moving the Bug reference to the meta data in the Git commit footer?

Hi

[#] has been the Bugzilla ID since time immemorial e.g. org.eclipse.emf commit

commit 7579495e9063bba1e238781956acc0db32034a56
Author: emerks <emerks> 2004-03-09 20:42:50
Committer: emerks <emerks> 2004-03-09 20:42:50
...

[54201] Support a JET nature for org.eclipse.emf.ecore (and .cvsignore runtime folder)

I have continued to follow the 'IBM' practice of [#] for as long as I have been an Eclipse committer.

IIRC EGit reacted to a "what no [#] support" outcry by supporting it.

Regards

Ed Willink


On 31/05/2018 15:09, Daniel Megert wrote:
> You think it's not an improvement, but do you think it's worse?

Yes, definitely. What does # in [#] mean? Change ID? Bugzilla ID? Git issue ID? ... Just to save 2 characters? Really?

Dani



From:        Mickael Istria <mistria@xxxxxxxxxx>
To:        "General development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>
Date:        31.05.2018 16:05
Subject:        Re: [eclipse-dev] Moving the Bug reference to the meta data in the Git commit footer?
Sent by:        eclipse-dev-bounces@xxxxxxxxxxx






On Thu, May 31, 2018 at 2:34 PM, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
I disagree that this is an improvement

What are your criteria about acceptable commit messages?
You think it's not an improvement, but do you think it's worse?

That said, Lars comment about autolinking from Gerrit is important, and before adopting this, we need to make sure that linking works or at least is going to work.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=421151already covers that.
 
and it only saves 2 and not 4 characters.

I think you forgot to count the whitespaces._______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev




_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev


Virus-free. www.avast.com

Back to the top