[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [eclipse-dev] Moving the Bug reference to the meta data in the Git commit footer?
|
+1, I like the current set up with the bug ID and title in the header.
Just a number is too vague IMO.
Eric
On 05/31/2018 10:09 AM, Daniel Megert wrote:
You think it's not an improvement, but do you think it's worse?
Yes, definitely. What does # in [#] mean? Change ID? Bugzilla ID? Git
issue ID? ... Just to save 2 characters? Really?
Dani
From: Mickael Istria <mistria@xxxxxxxxxx>
To: "General development mailing list of the Eclipse project."
<eclipse-dev@xxxxxxxxxxx>
Date: 31.05.2018 16:05
Subject: Re: [eclipse-dev] Moving the Bug reference to the meta data in
the Git commit footer?
Sent by: eclipse-dev-bounces@xxxxxxxxxxx
------------------------------------------------------------------------
On Thu, May 31, 2018 at 2:34 PM, Daniel Megert
<_daniel_megert@xxxxxx.com_ <mailto:daniel_megert@xxxxxxxxxx>> wrote:
I disagree that this is an improvement
What are your criteria about acceptable commit messages?
You think it's not an improvement, but do you think it's worse?
That said, Lars comment about autolinking from Gerrit is important, and
before adopting this, we need to make sure that linking works or at
least is going to work.
_https://bugs.eclipse.org/bugs/show_bug.cgi?id=421151_already covers that.
and it only saves 2 and not 4 characters.
I think you forgot to count the
whitespaces._______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe
from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev
_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/eclipse-dev
