[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [Dltk-dev] profiling stuff..
|
yeah this is with formatting always a bit of a problem
Will solve itself ofcourse...
But if somebody wants to do i at once over the complete source?
These discussions about formatting/code style is coming up in every open source or closed source project i worked on :)
I still dont get it that it will not be solved at the right level.. (CVS/SVN)
So that on checkout the source is formatted exactly how you as a user/developer wants to have it.. (personal preference)
and when it is checked back in. It is formatted auto right before checking (server side) to the server format preference (that never changes)
Then it just works for everybody and the repo will also always be in the same state.
johan
On Mon, Jun 2, 2008 at 2:29 PM, Alex Panchenko <
alex@xxxxxxxxx> wrote:
Johan,
Your patch looks good.
I committed ModelElement.equals() optimization myself today, so please update.
Small point about formatting changes - it would be better to
a) avoid formatting changes when it is possible
OR
b) commit formatting changes separately
So it would be easier to analyze file history if needed.
Alex
Johan Compagner wrote:
Ok
i made a little bit more improvements to that area.
any objections with the patch that is attached?
I also changed the internal variable of ModelElementInfo from an [] to a List (null if nothing)
Because at my place that grows to almost 400 and every add does an array copy
And this also happens constantly even with typing because then also the source is parsed.
johan
