Re: [che-dev] Update of the java formatter plugin

[Florent Benoit <fbenoit@xxxxxxxxxx>]

Hello,

I've merged all PR.

This is done for master branches (5.0.20-SNAPSHOT) and che6 (6.0.0-M1-SNAPSHOT) branches in all repositories

if you have issues, let me know,

thanks

Florent

On Thu, Oct 19, 2017 at 10:36 AM, Florent Benoit <fbenoit@xxxxxxxxxx> wrote:

Hello,

I will update the java formatter used in Eclipse Che to the version 2.0.0

https://github.com/eclipse/che-parent/pull/33

It includes fixes/enhancement requested by che developers

• display of invalid files (I've provided a pull request https://github.com/coveo/fmt-maven-plugin/pull/17)
• add threadSafe flag (Provided as well as part of pull request) so there is no warning when you run the build with parallel flags.

If you have an invalid formatted file, it will be reported now with output like:

[ERROR] Found 1 non-complying files, failing build

[ERROR] Non complying file: ..../wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/environment/server/DefaultServicesStartStrategy.java

[INFO] ------------------------------------------------------------------------

[INFO] BUILD FAILURE

[INFO] ------------------------------------------------------------------------

It includes as well a new version of the formatting rules : 1.4

https://github.com/google/google-java-format/releases/tag/google-java-format-1.4

Due to the change of formatting rules, you will have to update plugins (if you're using some) to be compliant with 1.4 level

you can find link to plugins at https://github.com/google/google-java-format/#using-the-formatter

Regards,

Florent