Re: [che-dev] Update of the java formatter plugin

[Florent Benoit <fbenoit@xxxxxxxxxx>]

Sergii,

As the formatting rules are updated from 1.3 to 1.4 you have to get updates from

https://github.com/google/google-java-format/#using-the-formatter

If you're using only maven command : mvn fmt:format, nothing changed.

But let say you're using Eclipse IDE, then you'll have to download update of the google format plugin at https://github.com/google/google-java-format/releases/tag/google-java-format-1.4 (google-java-format-eclipse-plugin_1.4.0.jar)

If you're using IntelliJ, you'll find plugin here https://plugins.jetbrains.com/plugin/8527-google-java-format (picking up 1.4.* version of the plugin instead of 1.3.x)

etc.

Regards,

Florent

On Thu, Oct 19, 2017 at 10:40 AM, Sergii Kabashniuk <skabashn@xxxxxxxxxx> wrote:

On Thu, Oct 19, 2017 at 11:36 AM, Florent Benoit <fbenoit@xxxxxxxxxx> wrote:

Hello,

I will update the java formatter used in Eclipse Che to the version 2.0.0

https://github.com/eclipse/che-parent/pull/33

It includes fixes/enhancement requested by che developers

• display of invalid files (I've provided a pull request https://github.com/coveo/fmt-maven-plugin/pull/17)
• add threadSafe flag (Provided as well as part of pull request) so there is no warning when you run the build with parallel flags.

If you have an invalid formatted file, it will be reported now with output like:

[ERROR] Found 1 non-complying files, failing build

[ERROR] Non complying file: ..../wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/environment/server/DefaultServicesStartStrategy.java

[INFO] ------------------------------------------------------------------------

[INFO] BUILD FAILURE

[INFO] ------------------------------------------------------------------------

It includes as well a new version of the formatting rules : 1.4

https://github.com/google/google-java-format/releases/tag/google-java-format-1.4

Due to the change of formatting rules, you will have to update plugins (if you're using some) to be compliant with 1.4 level

Can you elaborate what does it mean :  "will have to update plugins (if you're using some)"

you can find link to plugins at https://github.com/google/google-java-format/#using-the-formatter

Regards,

Florent

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev

_______________________________________________
che-dev mailing list
che-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/che-dev