Re: [tycho-dev] Performance issue with root data files

[Igor Fedorenko <ifedorenko@xxxxxxxxxxxx>]

Yes, please open new bugzilla ticket and provide a sample standalone
project that demonstrates the problem.

--
Regards,
Igor

On 12-01-25 1:37 PM, Dahanne, Anthony wrote:
> Hey hey !
> Agreed, this is a tycho breach ;-)
> Bugzilla entry ?
>
>
>
> Le contenu de ce courriel s'adresse au destinataire seulement. Il contient de l'information pouvant être confidentielle. Vous ne devez ni le copier ni l'utiliser ni le divulguer à qui que ce soit à moins que vous soyez le destinataire ou une personne désignée autorisée. Si vous le receviez par erreur, veuillez nous aviser immédiatement et le détruire.
>
> The contents of this e-mail are intended for the named addressee only. It contains information that may be confidential. Unless you are the named addressee or an authorized designee, you may not copy or use it, or disclose it to anyone else. If you received it in error please notify us immediately and then destroy it.
>
>
> From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
> Sent: 25 janvier 2012 13:25
> To: tycho-dev@xxxxxxxxxxx
> Subject: Re: [tycho-dev] Performance issue with root data files
>
> The real bug here is that Tycho allowed resources outside of project basedir. This should have been rejected with a clear error message.
>
> --
> Regards,
> Igor
>
> On 12-01-25 11:46 AM, Dahanne, Anthony wrote:
> > Hello Tycho devs,
> > This morning, we found out, with a colleague of mine, that if you add such a root file definition in your build.properties :
> > root=file:../../plof.zip
> >
> > then tycho is going to recursively scan the ../../ directory, in search of plof.zip.
> >
> > The method executed is FileSet.recursiveScan , called from
> > RootFilePatternParser.addFilesFromPatterns
> >
> > So this behavior (recursively scanning the directories) is very good when you have root file "folder"
> > root=../../root/
> >
> > but for a file, it could be much more efficient if, instead of
> > recursively scanning, it picked up the right file path, and check it
> > with addFileIfMatch(subFile, result, baseDirPath);
> >
> > because, sometimes, scanning a whole filesystem for just a file, can take a long time...
> > Is it worth a bug creation ?
> > Thanks
> > Anthony
> >
> >
> > Le contenu de ce courriel s'adresse au destinataire seulement. Il contient de l'information pouvant être confidentielle. Vous ne devez ni le copier ni l'utiliser ni le divulguer à qui que ce soit à moins que vous soyez le destinataire ou une personne désignée autorisée. Si vous le receviez par erreur, veuillez nous aviser immédiatement et le détruire.
> >
> > The contents of this e-mail are intended for the named addressee only. It contains information that may be confidential. Unless you are the named addressee or an authorized designee, you may not copy or use it, or disclose it to anyone else. If you received it in error please notify us immediately and then destroy it.
> >
> >
> > _______________________________________________
> > tycho-dev mailing list
> > tycho-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/tycho-dev
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-dev
>
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-dev