Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [lsp4e-dev] LSP4e document corruption
  • From: Ahmed Hussain <ahmed@xxxxxxxxxx>
  • Date: Thu, 5 May 2022 15:22:24 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cocotec.io; dmarc=pass action=none header.from=cocotec.io; dkim=pass header.d=cocotec.io; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kQE2k5dOVYUuR0avEsbEpZ2HjF50VSVPNl5Osq5i2tU=; b=TXAWFzpsU2M0Dv3xGnlgTwR+Bsh4ahtxdVV9I0W//gvz/DBXAEH52VjN01HIyJBPgOlvQWOsHLJwjRSVbGxlu8oEE9HvLdhTsJ0snws/G+tPaCW8UWQlrgAt0VJI/t15z/qK7zfUcFbB9Y8A/KzmhOpRzVk5xVVImOhyYk0yCd4qjXaARTvtMmz6UYjPCRBKhVd2CeJjDcNv0tEmDgWxLhOCAYAd7U8BCB/6gyuuGzXbv1tPLCZ9RnNYJEetx42MqVSMBmXg+OlYDOUJUuXBAtB1npnqemyHtRGBD/JXgOvdX4udo0BFJjDBPmDSAfuRXBdxujsCTmC/z7zHFB3gpw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QHE9Q7qYnqrL8PosRq8ArMTLTCs1ztsW5KxaA5dC2EsqxOvmMbyLMxhAaCfgtquH4T/j1nT4bzxGdG2Vxw+MO5PzseB4gdBP0ZodcqoPSXNzG+bTC6ZYnUODMyzSAE2zLQ5skGwciCF3GsiF6sz9lU0rdKIqOgi0knXQm4+kI4xLQcwNyOc7pfXPf+vvRfIlUrWoK7ni9A9bmGggDhIwTiJ5nUh2DkeA7+saRnd0qut6JWTmj0T97INJLDnz8SqKGWYeK+tuqPT5rJWtMbbs38oRrSpTUfYo6BqyjgQcgqmOlftyhO6taXXMNGYEjp9i4ixXceIRkZZymiG6lRUm2g==
  • Delivered-to: lsp4e-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/lsp4e-dev/>
  • List-help: <mailto:lsp4e-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/lsp4e-dev>, <mailto:lsp4e-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/lsp4e-dev>, <mailto:lsp4e-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHYOfEJjzoSfYGYRkOT0S8KxGpL3azDi4UAgAAER4CAS6uYgIAABi2AgAFe+QCAAAkxAIAACjmA
  • Thread-topic: [lsp4e-dev] LSP4e document corruption

The joys of UI/integration testing…! Very willing to help look into it. I had a brief look at it all, but certainly haven’t found a magic bullet. I tried making a small improvement to the colour test by using a euclidian distance and a tolerance rather than an exact comparison, and I also tweaked the teardown logic to close the pipes to the server only at the output stream ends (so relying on their passing the EOF to the corresponding input streams) - that got rid of a few AsynchronousCloseExceptions.

Would those be worth submitting?

Cheers,
Ahmed


On 5 May 2022, at 15:45, Mickael Istria <mistria@xxxxxxxxxx> wrote:



On Thu, May 5, 2022 at 4:13 PM Ahmed Hussain via lsp4e-dev <lsp4e-dev@xxxxxxxxxxx> wrote:
Are there any TODOs to try and mitigate any of this, or advice for working with them generally?

The issues you mention are unfortunately familiar to everyone. While it would really welcome that someone tries to mitigate these, I'm not aware of any particular plan or even progress of how this can be done. I think you'll need to figure out the root causes and solutions by yourself. If you manage to improve that, it would be very welcome!


Back to the top