Re: [lsp4e-dev] Request to review patch

[Jonah Graham <jonah@xxxxxxxxxxxxxxxx>]

I have commented on the gerrit.

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com

On Thu, 21 Mar 2019 at 12:49, Ayush Krishna murthi <kmayush27399@xxxxxxxxx> wrote:

I commited a change with commit message "Fixes sonarcloud blocker bug" to resolve bug posted here. I am requesting to review separately not just assigning there because there i forgot to attach link to the bug, it might have troubled you, sorry for that. I will try to write descriptive commit message from now onward.

CI bot showing Code Review failed, am i missing something or misunderstood the problem statement? if the change is not required, i will abandon it. Please review.

Link to changes : Change l195f2aef

Thanks 

_______________________________________________
lsp4e-dev mailing list
lsp4e-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/lsp4e-dev