Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jsonb-dev] [jsonp-dev] [External] : Re: Volunteer to apply a package rename to TCKs to avoid `jakarta` namespace in test classes...

updating parsson version to 1.0.0 helped, except that I see some failures with and without my changes:

[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]   ClientTests.jsonParserCurrentEvent:1862 NoSuchMethod 'jakarta.json.stream.Json...
[ERROR]   ClientTests.testDuplicateKeysFirst:3214 NoClassDefFound jakarta/json/JsonConfi...
[ERROR]   ClientTests.testDuplicateKeysLast:3233 NoClassDefFound jakarta/json/JsonConfig...
[ERROR]   ClientTests.testDuplicateKeysNone:3194 NoClassDefFound jakarta/json/JsonConfig...
[ERROR]   ClientTests.jsonNumber21Test:347 NoSuchMethod 'jakarta.json.JsonNumber jakarta...
[INFO]
[ERROR] Tests run: 177, Failures: 0, Errors: 5, Skipped: 0

I'll create a draft pr with the changes so far.

On 1/11/22 4:28 PM, Lukas Jungmann wrote:
Use either -Psnapshots or update parsson version to 1.0.0 (in staging)

thanks,
—lukas

11. 1. 2022 v 21:56, Scott Marlow <smarlow@xxxxxxxxxx>:




On 1/11/22 2:44 PM, Scott Marlow wrote:

Hi,

Following up on the Platform ML discussion [1] about TCK package names not starting with `jakarta` package for various reasons.  I'm not sure if or when a TCK package rename PR would be merged but wanted to ask if having such a pr would help?  I'll give it a shot if yes.

Perhaps change from `jakarta.json.bind.tck` to `json.bind.tck`?

Perhaps change from jakarta.jsonp.tck` to `jsonp.tck`?

https://github.com/scottmarlow/jsonp/tree/tckrename has some initial possible package rename changes, however building the tck-impl folder fails with "Could not find artifact org.eclipse.parsson:parsson:jar:1.0.1-SNAPSHOT" failure.

Scott

Or something else, perhaps from the now-unofficial survey [2]?

Scott

[1] https://www.eclipse.org/lists/jakartaee-platform-dev/msg03130.html
[2] https://docs.google.com/forms/d/e/1FAIpQLSf2zO8dqSZuehho2kpnot09DPveV_jJpPAzVn93tiQLda54hw/viewform?vc=0&c=0&w=1&flr=0

_______________________________________________
jsonp-dev mailing list
jsonp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jsonp-dev__;!!ACWV5N9M2RV99hQ!dTX5e6suqeIBREERz7phoRJAZfoy8L-pRel9hms6CDA4QL0E7lKbHcAsgW9RTaRjxDg$

_______________________________________________
jsonp-dev mailing list
jsonp-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jsonp-dev

Back to the top