Re: [jdt-dev] [eclipse-dev] Automate check to warn about freeze on Gerri

[Mickael Istria <mistria@xxxxxxxxxx>]

Thanks all for the feedback, please see reactions inline.

On Tue, Dec 8, 2020 at 12:03 PM Noopur Gupta <noopur_gupta@xxxxxxxxxx> wrote:

This validation should be through a separate bot which will add a -1 on the Gerrit patch if the freeze period (taken from releng calendar) is active.

OK, and I agree here. I've opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=569541 to ask for a new bot.

 

• It should include a clear comment and link to the freeze plan section (similar to the CQ comment/link).

That's already covered

 

• It doesn't need to add any comment during the non-freeze period to avoid too many Gerrit messages.

OK, I tweaked the job configuration to ignore "Success", I think it should work, we'll see.

 

• The existing bot should continue to give a +1/-1 based on the Gerrit build status of the patch.

Sure, that is not changed at all; and having a separate bot would also comfort that.

 

• A single job is better due to centralization as the freeze/RC dates and rules are the same for all these projects.

OK.

• It will be good if we can rename this bot to something like Freeze Bot instead of Platform Bot for more clarity.

That's part of https://bugs.eclipse.org/bugs/show_bug.cgi?id=569541

Cheers,