Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-dev] [eclipse-dev] Automate check to warn about freeze on Gerrit
Thanks, Mickael for taking this up. Some of my thoughts (most of which are probably already implemented in your job):
  • This validation should be through a separate bot which will add a -1 on the Gerrit patch if the freeze period (taken from releng calendar) is active.
  • It should include a clear comment and link to the freeze plan section (similar to the CQ comment/link).
  • It doesn't need to add any comment during the non-freeze period to avoid too many Gerrit messages.
  • The existing bot should continue to give a +1/-1 based on the Gerrit build status of the patch.
  • A single job is better due to centralization as the freeze/RC dates and rules are the same for all these projects.
  • It will be good if we can rename this bot to something like Freeze Bot instead of Platform Bot for more clarity.
Regards,
Noopur
 
----- Original message -----
From: Mickael Istria <mistria@xxxxxxxxxx>
Sent by: eclipse-dev-bounces@xxxxxxxxxxx
To: "Eclipse JDT general developers list." <jdt-dev@xxxxxxxxxxx>
Cc: "General development mailing list of the Eclipse project." <eclipse-dev@xxxxxxxxxxx>
Subject: [EXTERNAL] Re: [eclipse-dev] [jdt-dev] Automate check to warn about freeze on Gerrit
Date: Tue, Dec 8, 2020 1:58 PM
 
At the moment, there is a single job on Platform which runs for equinox, jdt and pde as well. However, there seems to be a limitation that this job cannot vote back on non-Platform repo (I believe it's an issue regarding permissions of Platform Bot on other repositories, I asked about it on cbi-dev).
So 1 question is: should we prefer 1. a single job that runs against all repos (as it is now, assuming Platform Bot can vote on other repos), or 2. 1 job on each CI instance (equinox,platform,jdt,pde)? The benefits of 1 is stronger factorization and centralization; the benefit of 2 is more isolation and more control for project team on this check. I think it's mostly an organizational decision more than a technical one: can and should the Eclipse Top-Level Project mandate that check for all subprojects?
_______________________________________________
eclipse-dev mailing list
eclipse-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/eclipse-dev
 

Back to the top