Re: [jdt-dev] Requesting fast track access to JDT

[Lars Vogel <lars.vogel@xxxxxxxxxxx>]

Hi Stephan,

thanks for the offer to review. Sounds like you more interested in
patches which contain functional changes, I will add you to such
patches in the future.

Thanks.

Best regards, Lars

On Thu, Jun 14, 2018 at 7:46 PM, Stephan Herrmann
<stephan.herrmann@xxxxxxxxx> wrote:
> On 14.06.2018 19:17, Lars Vogel wrote:
>>
>> My offer stands to help with JDT work. I really don't think it is a good
>> investment of the current team to review releng or sonar warning patches.
>> They should focus on the complex stuff.
>
>
> Let's please distinguish releng work from sonar warning patches:
>
> * Some JDT committers may indeed see *releng work* as outside their
> responsibility.
>   (Obviously this doesn't count for Jay, who in reverse is frequently
> working
>    as Sravan's stand in).
>
> * If any *code change* is not worth the review by a JDT committer,
>   then the code change may just not be worth it. Committers need to
>   have full control over the code they are responsible for.
>
>> [...]
>>
>> Are you also willing to help in reviewing JDT UI patches?
>
>
> I believe that all volunteer committers are willing to do a review every
> now and then, provided they are convinced of a significant benefit of the
> patch.
> You may kindly ask me, but please also accept when my conclusion is
> negative.
> You probably get best results if you ask a person who has recently made
> changes in the same code area, or on a related topic.
>
> best,
> Stephan
>
> PS: Back to (releng) work...
>
> _______________________________________________
> jdt-dev mailing list
> jdt-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/jdt-dev



-- 
Eclipse Platform project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com