| Re: [jdt-dev] Requesting fast track access to JDT |
Thanks Lars. As mentioned in the direct mail, I have reviewed the first two ones which were related to language warnings. For the third, I've moved it to Sarika.
In general, for jdt.ui code, (apart from Noopur) you can ask for Sarika Sinha, Kalyan, or Vikas.
Sarika/Vikas/Kalyan: Please suggest any more names appropriate.
Regards,
ManojLars Vogel ---06/14/2018 07:28:41 PM---Thanks, Manoj for the reply. I will add you to a few of our reviews. How else is actively doing code
From: Lars Vogel <lars.vogel@xxxxxxxxxxx>
To: "Eclipse JDT general developers list." <jdt-dev@xxxxxxxxxxx>
Date: 06/14/2018 07:28 PMFax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com________
Subject: Re: [jdt-dev] Requesting fast track access to JDT
Sent by: jdt-dev-bounces@xxxxxxxxxxx
Thanks, Manoj for the reply. I will add you to a few of our reviews. How else is actively doing code reviews in JDT UI?
Best regards, Lars
On Thu, Jun 14, 2018 at 3:37 PM, Manoj Palat <manoj.palat@xxxxxxxxxx> wrote:Hi ,
@Stephan: Thanks for taking the initiative to reply. I agree with you - my vote is also a NO for JDT fast track access for the reasons cited.
As mentioned, JDT being at the bottom of the pyramid - so to say - will have higher chances of breaking intra-component as well other inter-component code. Also would like to repeat the point in the mail about the complexity of the bugs involved.
@Lars: Now to address the individual concern of not getting a response/review in time, if you don't get a response in a day or two depending on the priority, please add one more person appropriately among the JDT committers - this should help speedup the process.
Open to discussion if there are better ways to address this as well.
Regards,
Manoj
From: Stephan Herrmann <stephan.herrmann@xxxxxxxxx>
To: jdt-dev@xxxxxxxxxxx
Date: 06/14/2018 06:26 PM
Subject: Re: [jdt-dev] Requesting fast track access to JDT
Sent by: jdt-dev-bounces@xxxxxxxxxxx
Hi Lars,
Thanks for your offer to help. A few remarks from my side to get
the discussion started:
As you apply for fast track access, let's ask if JDT understaffed
in the sense of that eclipse-dev post?
I'm counting 13 active committers in JDT, which is a far cry from
the situation addressed by the fast track approach (which btw. was
created before the sub-project merge, at a time when individual
projects indeed had close to zero active committers).
So my vote on fast track is a clear NO.
Still, there is reason in calling JDT understaffed, as can be easily
seen in bugzilla[1]. The number of open bugs, however, is only a
secondary aspect, the primary being the difficulty to fix each single
bug in JDT. Difficulty caused both by inherent complexity and by the
responsibility to not break an entire ecosystem of consumers of JDT.
Whether or not the help offered by Lars would help the project at
net value is a question I'll be happy to discuss prior to any
official application for commit rights.
IMHO, it would greatly help the application, if the bug list shows
a handful of essential bug fixes that demonstrate an understanding
of the complex core business of JDT.
best,
Stephan
[1]
https://bugs.eclipse.org/bugs/report.cgi?classification= Eclipse&product=JDT& resolution=---&x_axis_field= target_milestone&y_axis_field= component&format=table&action="">wrap
On 12.06.2018 13:17, Lars Vogel wrote:
> Friends of the Java tooling,
>
> I would like to get fast track access to JDT. Fast track is our
> process to give existing top-level Eclipse committers access to others
> projects without a big contribution record. It is explained here:
> https://dev.eclipse.org/mhonarc/lists/eclipse-dev/ .msg10305.html
>
> This way I can help with simple tasks in the JDT project. For example,
> I recently helped with a releng activity for updating the EPL 1.0 to
> EPL 2.0 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=535318 ) and as
> Jay and Noopur are really busy, it is hard to get them to look at
> these patches.
>
>
> In the future I plan to help with releng activities, reducing the
> usage of deprecated platform API, fixing Sonar and Java compiler
> warnings and helping with code reviews.
>
> Here are my existing contributions:
>
> ~/git/eclipse.jdt.ui$ git shortlog --author "Vogel"
> Lars Vogel (36):
> Fixed bug 406478: [implementation][content assist] Use enhanced
> for loop for CompletionProposalCollector and
> CompletionProposalCategory
> Fixed bug 406463: [templates][content assist] Ctrl+Space without
> any starting letter shows to no templates
> Fixed bug 387272: [templates] SWT templates - add SelectionListener
> Bug 427883 - Use ArrayContentProvider in ExtractClassWizard
> Bug 433605 - [CSS] [dark theme] Provide reasonable JDT defaults
> for syntax color in the dark theme
> Bug 468424 - Add README.md (with content from the CONTRIBUTING.md file)
> Bug 468391 - Remove outdated org.eclipse.jdt.ui/notes directory
> Bug 468482 - Add License to README.md similar to JDT core
> Bug 479094 - Remove unused internal class TemplateContentProvider
> Bug 131445 - [templates] Provide templates that check for 'null'
> Bug 486899 - [templates] Using a variable name for
> word_selection or line_selection makes the template not being proposed
> anymore
> Bug 486903 - [Templates] Allow specifying a default value in
> case the word_selection is empty
> Bug 488432 - Remove redundant implementation for word_selection
> and line_selection template from JDT
> Bug 485860 - Remove unnecessary @See Javadoc from spelling
> engine to prepare for Bug 185695
> Bug 507381 - JDT method templates should use "void" as return
> type instead of "return_type"
> Bug 502061 - Remove ensurePreferenceStoreBackwardsCompatibility
> as 2x plug-ins are not supported anymore
> Fixed bug 477789: Change usage of SubProgressMonitor to
> SubMonitor in JDT UI
> Bug 501800 - [CSS] [dark theme] Cleanup wizard looks bad in the dark theme
> Bug 514516 - Add pseudo selector to preference styling in JDT to
> allow other projects to extend the preference styling
> Bug 517992 - Remove org.eclipse.ui.presentations.r21 from
> PluginsNotLoadedTest
> Bug 525607 - [Trivial] Remove redundant @see non Javadoc from
> SpellCheckEngineTestCase
> Bug 527082 - [hovering][preferences] Add "Popup" as search term
> to Hovers preference page
> Bug 527082 - [hovering][preferences] Add "Popup" as search term
> to Hovers preference page
> Bug 519783 - Adopt to change in - HTMLPrinter should migrate to
> StringBuilder
> Bug 530125 - Solve Performance - Method invokes inefficient
> Number constructor; use static valueOf instead in JDT UI
> Bug 531255 - Generate hashCode and equals should use verbs
> Bug 530766 - Open Type dialog should use verbs instead of OK
> Bug 531718 - Generate toString dialog should use verbs
> Bug 530125 - Update BREE of
> org.eclipse.jdt.ui.examples.javafamily to Java 8
> Bug 530125 - Adds @Override annotations for
> org.eclipse.jdt.ui.examples.javafamily
> Bug 531724 - Use verbs instead of OK in all JDT UI "Generate" dialogs
> Bug 475823 - Adjusts CleanUpStressTest to new default Eclipse formatter
> Bug 533171 - Remove usage of deprecated Logger.global in
> org.eclipse.jdt.text.tests and org.eclipse.jdt.ui.tests
> Bug 481179 - New words for spellcheck
> Bug 531441 - [clean up] Cleanup action: Remove redundant modifiers
> Bug 535191 - POM version change for 4.9 release
>
> git shortlog --author "Vogel"
> Lars Vogel (12):
> Bug 470199 - Remove outdated _buildnotes_jdt-core.html
> Bug 473178 - Remove redundant type arguments (1.7 or highter)
> from Java 7 code in JDT core
> Bug 473178 - Remove redundant type arguments (1.7 or highter)
> from Java 7 code in JDT core
> Bug 473178 - Remove redundant type arguments (1.7 or highter)
> from Java 7 code in JDT core
> Bug 473178 - Remove redundant type arguments (1.7 or highter)
> from Java 7 code in JDT core
> Bug 479130 - Rename
> org.eclipse.jdt.core.tests.model/workspace/TypeResolve from
> org.eclipse.jdt.core to TypeResolve
> Bug 504040 - Remove usage of marked for deletion WorkbenchHelp
> from org.eclipse.jdt.core.tests.model
> Bug 527597 - Please add @Override annotations for org.eclipse.jdt.apt.core
> Bug 530321 - Add "apt" as search term for annotation processing
> in the preferences
> Bug 475823 - "Eclipse" default formatter should not add line
> breaks to @params in Javadoc
>
> Version 4.9 update as prep for EPL 2.0 change
> Bug 535318 - Update license to EPL-2.0 for jdt.core in about.html
>
> ~/git/eclipse.jdt.debug$ git shortlog --author "Vogel"
> Lars Vogel (3):
> Bug 535191 - POM version change for 4.9 release
> Version 4.9 updates as prep for the EPL 2.0 update
> Bug 535318 - Update license to EPL-2.0 for jdt.debug in about.html
>
> Thanks, Lars
>
>
_______________________________________________
jdt-dev mailing list
jdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-dev
_______________________________________________
jdt-dev mailing list
jdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-dev
--
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352______________________________ https://dev.eclipse.org/_________
jdt-dev mailing list
jdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visitmailman/listinfo/jdt-dev
_______________________________________________
jdt-dev mailing list
jdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-dev