Hi all,
I want to propose some name changes in the ecore model. I
think the flavor concept is not the most intuitive and since we call them
mappings in the UI anyway, we should probably call them mappings in the model.
Some of these were named this way because the class name matches the annotation
name, but I don’t think we necessarily have to do that. Here are
the proposed changes:
Basic -> BasicMapping
ColumnPersistentAttributeFlavor -> ColumnMapping
Embedded -> EmbeddedMapping
GeneratorPersistentAttributeFlavor -> Not
sure about this one
Id -> IdMapping
(I think Mike Keith was opposed to calling this a mapping, but he had no other
suggestions for what to call it)
OneToMany -> OneToManyMapping
OneToOne -> OneToOneMapping
ManyToMany -> ManyToManyMapping
ManyToOne -> ManyToOneMapping
NullPersistentAttributeFlavor -> InvalidMapping
(or maybe NullMapping, but a null mapping is never valid so InvalidMapping
seems to be more descriptive)
ReferencePersistentAttributeFlavor -> ReferenceMapping
Transient -> TransientMapping
(this one is a bit odd, any suggestions?)
Version -> VersionMapping
Should we also rename PersistentAttributeFlavor and
PersistentTypeFlavor while we’re at it? PersistentAttributeMapping
and PersistentTypeMapping maybe? And what about Entity, Embeddable, and
MappedSuperclass, should those change?
Let me know if you like these names, have other suggestions,
and if you are opposed to me making the changes now.
Thanks,
Karen